Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change use of Mycroft JSON config file to a skill-only YAML configuration file #14

Closed
5 of 7 tasks
LinusSkucas opened this issue Mar 3, 2019 · 4 comments
Closed
5 of 7 tasks
Assignees
Labels
bug Something isn't working enhancement Betterify something

Comments

@LinusSkucas
Copy link
Owner

LinusSkucas commented Mar 3, 2019

Using Config file with self.config in skills will end with the 19.08 release. Change so that it uses another file if users don't want to use home. The file will be ~/.mycroft/email-skill/email.yml. I will use yaml.

Before 19.08:

  • Define self.config in the skill.

In the Longer Run:

  • Change code to use YAML file, over home settings, if existent.

  • Keep backwards compatibility with Config file

I might want to have the skill say if the user is using the old config file something like: You are using the old version of configuring the skill on the device. Please go to [insert url here] to learn more.

  • Update docs

    • Change the config file to the yaml file
    • Create a "moving" page which user will land on when directed by the skill (see above)
  • Promote change.

@LinusSkucas LinusSkucas added bug Something isn't working enhancement Betterify something labels Mar 3, 2019
@LinusSkucas LinusSkucas self-assigned this Mar 3, 2019
@LinusSkucas LinusSkucas pinned this issue Mar 3, 2019
@LinusSkucas LinusSkucas unpinned this issue Mar 3, 2019
@LinusSkucas
Copy link
Owner Author

LinusSkucas commented Mar 9, 2019

Found that I could get around this with the Mycroft Config. just define self.config My self. However, I should just switch it to yaml because its is nicer.

I'm going to keep the bug label on this issue until I define self.config in the skill.

Sample code which could do this:

from mycroft.configuration.config import DEFAULT_CONFIG, SYSTEM_CONFIG, USER_CONFIG
from mycroft.configuration import Configuration

self.config = Configuration.get([DEFAULT_CONFIG,
                                    SYSTEM_CONFIG,
                                    USER_CONFIG],
                                   cache=False)

@LinusSkucas LinusSkucas changed the title Discontinue use of config file Change use of Mycroft JSON config file to a skill-only YAML configuration file Mar 9, 2019
@JonahEmbry
Copy link

So what exactly do I have to do to get this skill to work? I've been fighting with this for the last couple days, so any help would be appreciated.

@LinusSkucas
Copy link
Owner Author

right now, the local configuration isn't working due to some changes made in Mycroft core. This is on my todo list.

@LinusSkucas
Copy link
Owner Author

Hi @JonahEmbry The skill has been updated to fix this problem, and has been submitted to the market place for review. Once it is accepted, you should use the new docs to configure the skill. Alternatively, just using the home.mycroft.ai settings has been verified to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Betterify something
Projects
None yet
Development

No branches or pull requests

2 participants