Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvme-list produces error log entry each time (Samsung 950 Pro) #550

Closed
dswarbrick opened this issue Dec 4, 2022 · 5 comments
Closed

nvme-list produces error log entry each time (Samsung 950 Pro) #550

dswarbrick opened this issue Dec 4, 2022 · 5 comments
Labels
enhancement New feature or request
Milestone

Comments

@dswarbrick
Copy link

dswarbrick commented Dec 4, 2022

nvme-cli 2.2.x (and possibly earlier 2.x versions) results in an error log entry being created whenever the nvme list command is executed, in a system with a Samsung 950 Pro. Version 1.16 did not exhibit this.

Drive firmware is 2B0QBXX7 (latest available), and according to smartctl, the supported NVMe version is < 1.2.

The produced error log entries are always the same:

# nvme error-log -e 2 /dev/nvme0
Error Log Entries for device:nvme0 entries:2
.................
 Entry[ 0]   
.................
error_count     : 200
sqid            : 0
cmdid           : 0xa00c
status_field    : 0x2002(INVALID_FIELD: A reserved coded value or an unsupported value in a defined field)
phase_tag       : 0
parm_err_loc    : 0
lba             : 0
nsid            : 0x1
vs              : 0
trtype          : The transport type is not indicated or the error is not transport related.
cs              : 0
trtype_spec_info: 0
.................
 Entry[ 1]   
.................
error_count     : 199
sqid            : 0
cmdid           : 0x200a
status_field    : 0x2002(INVALID_FIELD: A reserved coded value or an unsupported value in a defined field)
phase_tag       : 0
parm_err_loc    : 0
lba             : 0
nsid            : 0x1
vs              : 0
trtype          : The transport type is not indicated or the error is not transport related.
cs              : 0
trtype_spec_info: 0
.................

Since this system runs a Prometheus node_exporter textfile collector (https://github.com/prometheus-community/node-exporter-textfile-collector-scripts/blob/master/nvme_metrics.sh), which is executed at regular intervals, the nvme list command within that script will continually produce error log entries.

Additionally, the kernel log records errors such as these when the nvme-list command is performed:

[185931.468688] nvme0: Admin Cmd(0x6), I/O Error (sct 0x0 / sc 0x2) MORE

Kernel is 6.0.10.

@keithbusch
Copy link
Contributor

These are occuring from attempting optional identify commands that we have no spec defined way if knowing if they're supported without trying. The errors are harmless and it's unfortunate some drives decided to add entries for these in the error logs.

As for the kernel message spam, we've fixed that up in 6.1, and I believe has been ported to the most current 6.0 stable.

@dswarbrick
Copy link
Author

@keithbusch Thank you for the clarification. I guess I will need to find some way of muting / ignoring the ever-increasing error log counter on this particular model.

@igaw
Copy link
Collaborator

igaw commented Dec 7, 2022

  • kernel error log fix: torvalds/linux@d7ac8dc

  • @jk-ozlabs introduced a quirk framework for libnvme-mi to address some fallouts with the MI interface. We might want to do add such a framework also for libnvme. But this is for the next major version aka libnvme 2.0

@igaw igaw added the enhancement New feature or request label Dec 7, 2022
@igaw igaw transferred this issue from linux-nvme/nvme-cli Dec 7, 2022
@igaw igaw added this to the 2.0 milestone Dec 7, 2022
@Bacto
Copy link

Bacto commented Jan 18, 2023

FYI, I get the same problem with a SAMSUNG PM983 (MZQLB960HAJR-00007) and firmware EDA5702Q.

@igaw
Copy link
Collaborator

igaw commented Dec 19, 2023

With libnvme v1.7 and the kernel release 6.8 this is fixed.

@igaw igaw closed this as completed Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants