Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mismatch argconfig_type in submit_io() #18

Closed
DaisukeIwai opened this issue Jul 1, 2015 · 3 comments
Closed

mismatch argconfig_type in submit_io() #18

DaisukeIwai opened this issue Jul 1, 2015 · 3 comments

Comments

@DaisukeIwai
Copy link

regress issues read/write command with --data_size=4k,
however argconfig_type in submit_io()'s data_size is "CFG_POSITIVE".
I guess either

  • replace CFG_POSITIVE as CFG_LONG_SUFFIX in nvme.c line 2608
    or
  • replace RAND_SIZE=4k as RAND_SIZE=4096 in regress line 29
    may be applied.

c8aab96

@sbates130272
Copy link
Contributor

I would prefer to fix this in nvme.c. Let me see why this was never spotted before now and get back to you, Thanks for raising it as an issue. Does this break regress for you? If so can you tell me something about your system?

@sbates130272
Copy link
Contributor

OK fixed along with a nasty bug where submit_io always returned 0! Thanks.

@DaisukeIwai
Copy link
Author

Thanks for reply & quck fix. Yes, regress with c8aab96 breaks with "free(): invalid next size (fast)" in submit_io(). --data_size=4k was equal to --data_size=4, only 4byte size of buffer is not enough for read data buffer. Passed with f579aa4 on Ubuntu 15.04 x86_64 and our NVMe device. thank you,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants