Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(housekeeping): send space warning erery 5 mins #526

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

black-desk
Copy link
Contributor

This housekeeping module is added
because X-org has a problem in XSession script,
which cause XSession failed to start
when user's home directory is full.

Basically, XSession fails because
the script redirect std error to ~/.xerrors
and failed to write to that file.

This bug is fixed in UOS and deepin,
by update the XSession script to ignore that write failure.

So full of user home directory is not such a big issue now.

We can send this warning not that frequently as we used to be,
as some users may consider this warning annoying.

Related: linuxdeepin/developer-center#4685
Signed-off-by: black-desk me@black-desk.cn

This housekeeping module is added
because X-org has a problem in XSession script,
which cause XSession failed to start
when user's home directory is full.

Basically, XSession fails because
the script redirect std error to ~/.xerrors
and failed to write to that file.

This bug is fixed in UOS and deepin,
by update the XSession script to ignore that write failure.

So full of user home directory is not such a big issue now.

We can send this warning not that frequently as we used to be,
as some users may consider this warning annoying.

Related: linuxdeepin/developer-center#4685
Signed-off-by: black-desk <me@black-desk.cn>
@black-desk
Copy link
Contributor Author

Need to update this line:

https://github.com/deepin-community/xorg/blob/25a4a5f36662a53ecf3d20e442d853654956313b/debian/local/Xsession#L97

to:

echo "$PROGNAME: X session started for $LOGNAME at $(date)" || true

@Zeno-sole

black-desk added a commit to black-desk/xorg that referenced this pull request Jun 21, 2023
When user home is full,
scripts write to a file in user home will failed.

After redirect stdout and stderr to ERRFILE,
aka $HOME/.xsession-errors,
this script echo a line to that file.

This echo might failed and make this script exit with error.
In that case, the session leader will not able to even start.

Releated: linuxdeepin/developer-center#4685
Releated: linuxdeepin/dde-daemon#526
black-desk added a commit to black-desk/xorg that referenced this pull request Jun 21, 2023
When user home is full,
scripts write to a file in user home will failed.

After redirect stdout and stderr to ERRFILE,
aka $HOME/.xsession-errors,
this script echo a line to that file.

This echo might failed and make this script exit with error.
In that case, the session leader will not able to even start.

Releated: linuxdeepin/developer-center#4685
Releated: linuxdeepin/dde-daemon#526
Signed-off-by: black-desk <me@black-desk.cn>
@black-desk
Copy link
Contributor Author

@SuperEffie

Zeno-sole pushed a commit to deepin-community/xorg that referenced this pull request Jun 21, 2023
When user home is full,
scripts write to a file in user home will failed.

After redirect stdout and stderr to ERRFILE,
aka $HOME/.xsession-errors,
this script echo a line to that file.

This echo might failed and make this script exit with error.
In that case, the session leader will not able to even start.

Releated: linuxdeepin/developer-center#4685
Releated: linuxdeepin/dde-daemon#526
Signed-off-by: black-desk <me@black-desk.cn>
@black-desk
Copy link
Contributor Author

@dengbo11 先不合这个 还有其他问题没处理完

Copy link
Member

@BLumia BLumia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit message 和 PR 标题写的都是五分钟,怎么代码是十分钟。。

@@ -50,7 +50,7 @@ func (d *Daemon) Start() error {
return nil
}

d.ticker = time.NewTicker(time.Minute * 1)
d.ticker = time.NewTicker(time.Minute * 10)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
d.ticker = time.NewTicker(time.Minute * 10)
d.ticker = time.NewTicker(time.Minute * 5)

@black-desk
Copy link
Contributor Author

commit message 和 PR 标题写的都是五分钟,怎么代码是十分钟。。

因为暂时没打算合这个了,所以一直没更新

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Dec 27, 2023

TAG Bot

New tag: 6.0.30
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #596

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 5, 2024

TAG Bot

New tag: 6.0.31
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #604

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 17, 2024

TAG Bot

New tag: 6.0.32
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #609

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 26, 2024

TAG Bot

New tag: 6.0.33
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #613

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 26, 2024

TAG Bot

New tag: 6.0.34
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #614

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Feb 6, 2024

TAG Bot

New tag: 6.0.35
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #616

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Mar 25, 2024

TAG Bot

New tag: 6.0.36
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #620

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Apr 15, 2024

TAG Bot

New tag: 6.0.37
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #621

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Apr 23, 2024

TAG Bot

New tag: 6.0.38
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #626

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Apr 30, 2024

TAG Bot

New tag: 6.0.39
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #628

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jun 5, 2024

TAG Bot

New tag: 6.0.40
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #632

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jun 21, 2024

TAG Bot

New tag: 6.0.41
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #634

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jul 24, 2024

TAG Bot

New tag: 6.0.42
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #641

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jul 24, 2024

TAG Bot

New tag: 6.0.43
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants