Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: in the Community Edition, right clicking to modify the account i… #351

Closed
wants to merge 1 commit into from

Conversation

Tw1012
Copy link

@Tw1012 Tw1012 commented Jul 1, 2024

…nformation has no reaction

Determine the system version and pass different parameters to the DBUS interface ShowPage according to the version.

Log: in the Community Edition, right clicking to modify the account information has no reaction
Bug: https://pms.uniontech.com/bug-view-252625.html

…nformation has no reaction

Determine the system version and pass different parameters to the DBUS
interface ShowPage according to the version.

Log: in the Community Edition, right clicking to modify the account information has no reaction
Bug: https://pms.uniontech.com/bug-view-252625.html
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Tw1012

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • EditAccount函数中,对common::systemInfo().isOldVersion()的调用可能需要错误处理机制,以防systemInfo()返回无效或未定义的版本信息。
  • 新增代码中没有对m_controlInter->call的返回值进行处理,可能会导致未处理的初始化错误。
  • 函数EditAccount的命名不够明确,建议使用更具描述性的名称以表明其功能。

是否建议立即修改:

@Tw1012 Tw1012 closed this by deleting the head repository Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants