Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 新增一个含有内外边界的blurEffectWidget #582

Closed
wants to merge 2 commits into from

Conversation

mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Jun 19, 2024

从gerrit摘取, 用于统一Qt Widgets程序的外边框

Issue: linuxdeepin/developer-center#8342

由于在blurEffectWidget的paintEvent中绘制内边界,边界会属于窗口内,当内边界带透明度时,会透过窗口下的颜色,必须在blurEffectWidget的painterEvent之后再绘制边界
此需求需要应用适配,将DBlurEffectWidget替换为DBlurEffectWithBorderWidget即可(还需要在paintEvent中替换)

Log: 新增一个含有内外边界的blurEffectWidget
Task: https://pms.uniontech.com/task-view-330413.html
Influence: 适配后的所有模糊窗口
Change-Id: I689b51810259494d57ecaf08190230d10f8837a6
优化新增类的 初始化,变量赋值顺序,新增常量等

Log: 优化新增的DBlurEffectWithBorderWidget
Task: https://pms.uniontech.com/task-view-330413.html
Influence: 适配后的所有模糊窗口
Change-Id: Ica08eb1fd8878aa2178f7409df142129970225c3
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Jun 19, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#582
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • DBlurEffectWithBorderWidget类的构造函数中,使用了connect信号与槽机制来处理窗口圆角和主题类型的变化。这些连接应该被检查以确保在未来的Qt版本中不会出现问题。
  • paintEvent方法中使用了QPainter来绘制边框,但是没有看到对边框颜色的修改,这可能是一个遗漏,应该根据主题类型来设置边框颜色。
  • DBlurEffectWithBorderWidgetPrivate类的构造函数直接使用了DObjectPrivate的构造函数,但是没有传递任何参数,这可能是一个错误,应该传递正确的父对象。
  • DBlurEffectWithBorderWidgetPrivate类中的themeType成员变量应该有一个枚举类型来明确表示主题类型,而不是使用字符串。

是否建议立即修改:

@mhduiy mhduiy changed the title chore: 新增一个含有内外边界的blurEffectWidget feat: 新增一个含有内外边界的blurEffectWidget Jun 19, 2024
@@ -0,0 +1,27 @@
// SPDX-FileCopyrightText: 2017 - 2024 UnionTech Software Technology Co., Ltd.
//
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024

@kegechen
Copy link
Contributor

没太必要加 @zccrs

@mhduiy mhduiy closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants