Skip to content
This repository has been archived by the owner on Nov 7, 2021. It is now read-only.

Some suggestions #1

Open
manishrjain opened this issue Oct 30, 2018 · 0 comments
Open

Some suggestions #1

manishrjain opened this issue Oct 30, 2018 · 0 comments

Comments

@manishrjain
Copy link

Copying this from Slack:

  • I'd remove this line: https://github.com/linuxerwang/dgraph-bench/blob/master/main.go#L120
  • I'd also ideally push many updates in one txn. So, not just one person, but say a 100 people in one txn, so each txn is doing some significant amount of work.
  • When you're doing a mutate, better to give it a very generous timeout. Dgraph internally would retry the mutate. So, don't set it to 3s here: https://github.com/linuxerwang/dgraph-bench/blob/master/main.go#L103 I'd either use context.Background(), or just like 10m or so.
  • If Dgraph gives you a pushback (in the error, to say server is overloaded or something), then you'd want to add some artificial delay.
  • Have a look at our live loader code to see how we batch and process many updates into one txn.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant