Skip to content
This repository has been archived by the owner on Jul 25, 2020. It is now read-only.

Revisit the bundled sqlite library #27

Closed
linuxfood opened this issue May 6, 2013 · 6 comments
Closed

Revisit the bundled sqlite library #27

linuxfood opened this issue May 6, 2013 · 6 comments

Comments

@linuxfood
Copy link
Owner

I was just looking over things since #26 was raised, and thinking that the bundled sqlite should probably either be removed or updated, since it was last updated a year ago, and I know there have been quite a few updates since then.

@kud1ing
Copy link
Contributor

kud1ing commented May 6, 2013

I had the impression that sqlite3.c is currently not used anyway since there is no Makefile compiling and linking it,
and that a system-wide libsqlite* is dynamically linked.

@linuxfood
Copy link
Owner Author

Oh dear. It seems it really has been a long time since I mucked around with the code.
It used to have this hilarious little hack that would pass in sqlite.c in the build parameters in sqlite.rc I'm sure you can see in the history somewhere. Anyhoo, since it's not used anymore, consider this a request to nuke it.

@kud1ing
Copy link
Contributor

kud1ing commented May 7, 2013

Do you mean #[nolink] #[link_args = "sqlite3.c"]?

@linuxfood
Copy link
Owner Author

Yeah, that's the one, but it obviously hasn't been working in awhile.

@kud1ing
Copy link
Contributor

kud1ing commented May 16, 2013

I think that should still work.

But: my understanding is that this trick works because we are linking with cc. This might change in the future: rust-lang/rust#1300

@kud1ing
Copy link
Contributor

kud1ing commented May 21, 2013

Removed in #33
We can add an up-to-date version at a later point in time.

@kud1ing kud1ing closed this as completed May 21, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants