Skip to content

Commit

Permalink
Fixed Skype chat window stealing the focus
Browse files Browse the repository at this point in the history
  • Loading branch information
@clefebvre
clefebvre committed Jun 9, 2012
1 parent d1f25b2 commit c5bbcad
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions js/ui/windowAttentionHandler.js
View file
Expand Up @@ -23,9 +23,9 @@ WindowAttentionHandler.prototype = {
// toolbar windows which would result into a notification even though GIMP itself is
// focused.
// We are just ignoring the hint on skip_taskbar windows for now.
// (Which is the same behaviour as with metacity + panel)
// (Which is the same behaviour as with metacity + panel)

if (!window || window.has_focus() || window.is_skip_taskbar())
if (!window || window.has_focus() || window.is_skip_taskbar() || window.get_wm_class() == "Skype")
return;

if (this._tracker.is_window_interesting(window)) {
Expand Down

4 comments on commit c5bbcad

@nikolaykhodov
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can manually apply patch to /usr/share/cinnamon/js/ui/windowAttentionHandler.js (on Mint 13) and then restart mdm.

@eean
Copy link

@eean eean commented on c5bbcad Feb 26, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this commit at all.

No application should ever steal focus from the user just because it has something to alert them about. I could see maybe a white list - for sure there might be some system-related thing that should steal focus (eg a daemon needs to ask for a root password or something). But in general NO.

@dalcde
Copy link
Contributor

@dalcde dalcde commented on c5bbcad Feb 26, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might help: #1392

@eean
Copy link

@eean eean commented on c5bbcad Feb 26, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now I won't send alerts when DESKTOP_SESSION says 'cinnamon'. If there's some way to communicate to apps that you don't have the bug anymore that'd be nice. I have no idea how to do that.

Please sign in to comment.