Permalink
Browse files

Fixed Skype chat window stealing the focus

  • Loading branch information...
clefebvre committed Jun 9, 2012
1 parent d1f25b2 commit c5bbcad1cc4cc8183f2556deef867d0fae5f0109
Showing with 2 additions and 2 deletions.
  1. +2 −2 js/ui/windowAttentionHandler.js
@@ -23,9 +23,9 @@ WindowAttentionHandler.prototype = {
// toolbar windows which would result into a notification even though GIMP itself is
// focused.
// We are just ignoring the hint on skip_taskbar windows for now.
// (Which is the same behaviour as with metacity + panel)
// (Which is the same behaviour as with metacity + panel)
if (!window || window.has_focus() || window.is_skip_taskbar())
if (!window || window.has_focus() || window.is_skip_taskbar() || window.get_wm_class() == "Skype")
return;
if (this._tracker.is_window_interesting(window)) {

4 comments on commit c5bbcad

@nikolaykhodov

This comment has been minimized.

Show comment
Hide comment
@nikolaykhodov

nikolaykhodov Oct 2, 2012

You can manually apply patch to /usr/share/cinnamon/js/ui/windowAttentionHandler.js (on Mint 13) and then restart mdm.

nikolaykhodov replied Oct 2, 2012

You can manually apply patch to /usr/share/cinnamon/js/ui/windowAttentionHandler.js (on Mint 13) and then restart mdm.

@eean

This comment has been minimized.

Show comment
Hide comment
@eean

eean Feb 26, 2013

I don't understand this commit at all.

No application should ever steal focus from the user just because it has something to alert them about. I could see maybe a white list - for sure there might be some system-related thing that should steal focus (eg a daemon needs to ask for a root password or something). But in general NO.

eean replied Feb 26, 2013

I don't understand this commit at all.

No application should ever steal focus from the user just because it has something to alert them about. I could see maybe a white list - for sure there might be some system-related thing that should steal focus (eg a daemon needs to ask for a root password or something). But in general NO.

@dalcde

This comment has been minimized.

Show comment
Hide comment
@dalcde

dalcde Feb 26, 2013

Contributor

This might help: #1392

Contributor

dalcde replied Feb 26, 2013

This might help: #1392

@eean

This comment has been minimized.

Show comment
Hide comment
@eean

eean Feb 26, 2013

For now I won't send alerts when DESKTOP_SESSION says 'cinnamon'. If there's some way to communicate to apps that you don't have the bug anymore that'd be nice. I have no idea how to do that.

eean replied Feb 26, 2013

For now I won't send alerts when DESKTOP_SESSION says 'cinnamon'. If there's some way to communicate to apps that you don't have the bug anymore that'd be nice. I have no idea how to do that.

Please sign in to comment.