Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar applet's support for vertical panels is unfinished (and glitchy) #6137

Closed
mbazley opened this issue Dec 28, 2016 · 14 comments
Closed

Comments

@mbazley
Copy link

mbazley commented Dec 28, 2016

See thread: https://forums.linuxmint.com/viewtopic.php?f=208&t=236185&p=1257947#p1257947

I think this image speaks for itself.

Currently, there is no way to get the calendar to show the date on a vertical panel without using a custom format string. It ignores the "Display the date" option in the "Date and Time Settings" button offered from the applet's menu - bug number 1. (Possibly a feature request.)

This situation is worsened by the fact there is no reasonable way to use a custom format string on a vertical panel. Firstly, I can't find any way to define newlines, thus making the custom format have less functionality than the default one (bug number 2). But even if it were possible, the default settings already change depending on the orientation of the panel, so why not have the ability to define two format strings - one for horizontal, and one for vertical? (Bug/feature request number 3.)

Finally (and fourthly), there is the effect that using overlong custom format strings currently has, but I'm going to report that one separately because it's mostly a bug with the panel itself and not just the calendar.

@leigh123linux
Copy link
Contributor

duplicate of #6109

@mbazley
Copy link
Author

mbazley commented Dec 28, 2016

I don't appreciate this issue being closed in favour of an issue that was also closed with no resolution. I concede that it turns out it is possible to insert newlines, although arguably the lack of documentation on how to do so is a bug in its own right.

It ignores the "Display the date" option in the "Date and Time Settings" button offered from the applet's menu - bug number 1.

This is still a bug.

why not have the ability to define two format strings - one for horizontal, and one for vertical?

This is still a feature request.

The other bug - lack of sanity checking on icon alignment - is still a bug, and still causes redraw glitches.

Are you announcing your intention to ignore them?

@leigh123linux
Copy link
Contributor

Are you announcing your intention to ignore them?

The devs are aware of the issues and don't need multiple duplicate reports

@mbazley
Copy link
Author

mbazley commented Dec 29, 2016

They do need at least one, though. Have you not noticed the other one was closed?

If it had not been closed, I would have noticed it when I skimmed the bug list for vertical panel-related issues a couple of days ago, as users are supposed to do before reporting potential duplicate bugs. Not to mention I wouldn't have wasted a couple of days and several forum members' time trying to track down the true cause of my symptoms. Furthermore, there's now nothing to stop somebody else making the exact same mistake in the future.

And this is supposed to be a bug tracker, after all. Do the devs just hold all of the bugs in their heads?

@leigh123linux
Copy link
Contributor

The devs have a private thread on slack for cinn-vertical-panels and it's issues.
If it makes you happy I will reopen it.

@leigh123linux leigh123linux reopened this Dec 29, 2016
@brownsr
Copy link
Member

brownsr commented Dec 30, 2016

@mbazley When I originally wrote the vertical panel changes for the calendar applet I quickly realised that the options for what clock would physically show in the panel were very limited. I decided to use a single locked format as the alternative was simply to disallow use of the calendar in a vertical panel. Subsequently we extended this so that people who were happy trying custom formats could do so. The default format in a vertical panel is %H%n%M by the way, the way to get a newline in is with the %n. You do get some very strange things happen in a vertical panel if the applet is wider than the panel - everything centre aligns to the central position of the widest applet in a panel section. (That's why I went with a locked format in the first place). The applet is not trimmed to avoid this because it is readily correctable by the user [i.e. use of a custom date format that actually fits].

I appreciate that some people will feel really strongly about wanting to see a full length date/time string, but the width of the panel is a fundamental constraint. The only way I can see a visually pleasing result being obtained with an over-long date string is to a) use a theme that has a completely transparent panel [I came across a couple like this] b) put the calendar applet in a panel section [top, middle, bottom] entirely on its own. Do experiment along those lines if that will suit you.

@mbazley
Copy link
Author

mbazley commented Dec 30, 2016

I've been experimenting. Would be nice if there was a way to change the time to see how it copes with 22:22, but the "Use network time" off switch has no effect. I can change the time all I like, and it just snaps back a second later without ever reaching the panel.

The principle bug here is actually the other one, #6138 (or #6109), which you say you encountered and had to work around. That was actually what moved me to report a bug in the first place. The icons disappeared without it being at all obvious where they had gone or what was causing this. If all that had happened was that the calendar went off the screen, I'd had known what was going on and how to fix it. The correct behaviour is to align to the widest applet or the panel width if this is smaller.

Still, at least I found out about the secret undocumented %n option, without which I wouldn't have been able to work out a satisfactory solution anyway. I might put in a PR to remove the link to foragoodstrftime.com (which itself links to a site that has since vanished) and replace it with inline documentation, since it doesn't seem like that much work. Lots of translation though...

The other suggestion, to have two configurable format strings, stands as well. This would make more sense, as the default vertical format string is a special case whereas the default horizontal one is also the default custom. This would provide an illustration of the use of %n too.

@jkterry1
Copy link

Why don't you just change the date/time format to %H%n%M (or in my opinion preferably %I%n%M) automatically when switching to a vertical taskbar? That seems simple to implement and seems like it would make everyone involved happier.

@shred
Copy link

shred commented Nov 19, 2017

I don't know if this is related, or if I should open a separate bug.

I use the calendar in a horizontal panel with a custom format (%a %d.%m. %H:%M:%S). After I updated to cinnamon-3.6.0-1.fc27, the calendar ignores my custom format, or anything else I type into the format configuration. As soon as I turn on custom format, it seems to use a hardcoded %H%n%M, which looks rather ugly on a horizontal pane.

Removing and re-adding the calendar applet to the panel did not resolve this problem.

@mtwebster
Copy link
Member

Not sure why that would occur for you in that version, 3.6.3 introduced a bug that caused that, and it has been fixed for the next point release

@mtwebster
Copy link
Member

For the main topic of this issue, honestly I think the only way to make the time/date look good on a vertical panel would be to make a separate applet, with different configuration controls - I'm thinking 2 configurable lines instead of one, and a smaller font.

@shred
Copy link

shred commented Nov 19, 2017

Yes, what I meant was that I updated from cinnamon-3.6.0-1.fc27 to cinnamon-3.6.3-1.fc27.

@Vahan86
Copy link

Vahan86 commented Jan 19, 2020

Still an issue in Cinnamon 4.4.8.

@brownsr
Copy link
Member

brownsr commented Jan 19, 2020

I don't honestly think there is a bug here now. The default format fits both styles of panel. If you choose a custom string then it's over to you. Choose too long a custom string in a vertical panel and it will be truncated. That appears to be a well behaved outcome. So I am not convinced there is either a bug or even a well defined feature request here. Closing.

Regards

Simon

@brownsr brownsr closed this as completed Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants