Looking glass work #3779
Merged
Looking glass work #3779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Odyseus
added a commit
to Odyseus/mint-themes
that referenced
this pull request
Mar 29, 2018
These classes/IDs/properties were removed because they aren't used anymore by any version of Cinnamon that this theme supports. - **.lg-*** and **#LookingGlassPropertyInspector**: Everything related to these classes and *ID* was removed from Cinnamon back in 2014 ([Cinnamon PR#3779](linuxmint/cinnamon#3779)). **#LookingGlassDialog** was kept because it's still used by Melange. But the styling of elements *inside* this *ID* (**#Toolbar**, **StScrollBar**, etc.) were removed because it seems that they were also removed. - **.end-session-dialog-***, **.hotplug-*** and **.polkit-dialog-***: Everything related to these classes was removed from Cinnamon back in 2013 ([Cinnamon commit where these classes were removed from the default theme](linuxmint/cinnamon@b8d1dbb)). - **.popup-menu** and **.popup-menu-boxpointer**: These classes were left for retro-compatibility with Cinnamon versions under 3.2.x. But since version 3.4.x of Cinnamon, it is not possible to make this theme retro-compatible due to the removal of the programmatically added spacing on the **TextIconApplet** prototype by [Cinnamon PR#6271](linuxmint/cinnamon#6271). I also checked the applets repository, and none of the applets are using these classes anymore. **Classes kept if the theme is built for Cinnamon version 3.0.x.** - **.menu-category-button-button:hover**: This selector's class never existed. And even if it is a typo meant to style the **menu-category-button-selected** class on hover, its result is horrendous. So, I removed it. - **#overview-corner**: The hot corner icons were removed by [Cinnamon PR#6423](linuxmint/cinnamon#6423). The images **overview.png** and **overview-hover.png** were also removed. - **.panel-button** and **.panel-menu**: This classes usage was removed in this [Cinnamon commit](linuxmint/cinnamon@91b0b76). - The third-party xlet called **Weather** defines the **panel-button** class to be used for styling, [but never really uses it](https://github.com/linuxmint/cinnamon-spices-applets/blob/master/weather%40mockturtl/files/weather%40mockturtl/applet.js#L123). - The third-party applet called **CPU Frequency Applet** uses the **panel-button** class [but then it removes it](https://github.com/linuxmint/cinnamon-spices-applets/blob/master/cpufreq%40mtwebster/files/cpufreq%40mtwebster/applet.js#L150). - **.panel-status-button**: Hard to pin-point were this class was removed. My guess is around [Cinnamon PR#4125](linuxmint/cinnamon#4125). What's easy to realize is that the styles defined in this class are almost the same as the styling for the **applet-box** class. Additionally, the **-natural-hpadding** and **-minimum-hpadding** properties defined in this class are never programmatically applied. - Class used by the default applet called **Keyboard** (UUID keyboard@cinnamon.org). I think that this class should be removed from this applet. - **.label-shadow**: This class is defined by the **TextShadower** prototype. This prototype hasn't been used in Cinnamon [since around 2012](linuxmint/cinnamon@3f25240) and, if it is usefull to know, it was removed from Gnome Shell [in 2015](333becef45d58be20ea0b9d4404c2c382a9db117). I removed it because [of the comment in this prototype's definition](https://github.com/linuxmint/Cinnamon/blob/master/js/ui/panel.js#L1201), which suggests that the prototype might get removed in case of it not been used anymore (my guess). - Removed `opacity` and `mouseover-opacity` properties from **#notification** selector. These properties were used before the **Have notifications fade out when hovered over** setting was introduced ([Cinnamon commit](linuxmint/cinnamon@dae0a21)). Now a days, neither of the properties are used programmatically nor the aforementioned setting exist.
Odyseus
added a commit
to Odyseus/mint-themes
that referenced
this pull request
Mar 29, 2018
These classes/IDs/properties were removed because they aren't used anymore by any version of Cinnamon that this theme supports. - **.lg-*** and **#LookingGlassPropertyInspector**: Everything related to these classes and *ID* was removed from Cinnamon back in 2014 ([Cinnamon PR#3779](linuxmint/cinnamon#3779)). **#LookingGlassDialog** was kept because it's still used by Melange. But the styling of elements *inside* this *ID* (**#Toolbar**, **StScrollBar**, etc.) were removed because it seems that they were also removed. - **.end-session-dialog-***, **.hotplug-*** and **.polkit-dialog-***: Everything related to these classes was removed from Cinnamon back in 2013 ([Cinnamon commit where these classes were removed from the default theme](linuxmint/cinnamon@b8d1dbb)). - **.popup-menu** and **.popup-menu-boxpointer**: These classes were left for retro-compatibility with Cinnamon versions under 3.2.x. But since version 3.4.x of Cinnamon, it is not possible to make this theme retro-compatible due to the removal of the programmatically added spacing on the **TextIconApplet** prototype by [Cinnamon PR#6271](linuxmint/cinnamon#6271). I also checked the applets repository, and none of the applets are using these classes anymore. **Classes kept if the theme is built for Cinnamon version 3.0.x.** - **.menu-category-button-button:hover**: This selector's class never existed. And even if it is a typo meant to style the **menu-category-button-selected** class on hover, its result is horrendous. So, I removed it. - **#overview-corner**: The hot corner icons were removed by [Cinnamon PR#6423](linuxmint/cinnamon#6423). The images **overview.png** and **overview-hover.png** were also removed. - **.panel-button** and **.panel-menu**: This classes usage was removed in this [Cinnamon commit](linuxmint/cinnamon@91b0b76). - The third-party xlet called **Weather** defines the **panel-button** class to be used for styling, [but never really uses it](https://github.com/linuxmint/cinnamon-spices-applets/blob/master/weather%40mockturtl/files/weather%40mockturtl/applet.js#L123). - The third-party applet called **CPU Frequency Applet** uses the **panel-button** class [but then it removes it](https://github.com/linuxmint/cinnamon-spices-applets/blob/master/cpufreq%40mtwebster/files/cpufreq%40mtwebster/applet.js#L150). - **.panel-status-button**: Hard to pin-point were this class was removed. My guess is around [Cinnamon PR#4125](linuxmint/cinnamon#4125). What's easy to realize is that the styles defined in this class are almost the same as the styling for the **applet-box** class. Additionally, the **-natural-hpadding** and **-minimum-hpadding** properties defined in this class are never programmatically applied. - Class used by the default applet called **Keyboard** (UUID keyboard@cinnamon.org). I think that this class should be removed from this applet. - **.label-shadow**: This class is defined by the **TextShadower** prototype. This prototype hasn't been used in Cinnamon [since around 2012](linuxmint/cinnamon@3f25240) and, if it is usefull to know, it was removed from Gnome Shell [in 2015](333becef45d58be20ea0b9d4404c2c382a9db117). I removed it because [of the comment in this prototype's definition](https://github.com/linuxmint/Cinnamon/blob/master/js/ui/panel.js#L1201), which suggests that the prototype might get removed in case of it not been used anymore (my guess). - Removed `opacity` and `mouseover-opacity` properties from **#notification** selector. These properties were used before the **Have notifications fade out when hovered over** setting was introduced ([Cinnamon commit](linuxmint/cinnamon@dae0a21)). Now a days, neither of the properties are used programmatically nor the aforementioned setting exist.
Odyseus
added a commit
to Odyseus/mint-themes
that referenced
this pull request
Mar 29, 2018
These classes/IDs/properties were removed because they aren't used anymore by any version of Cinnamon that this theme supports. - **.lg-*** and **#LookingGlassPropertyInspector**: Everything related to these classes and *ID* was removed from Cinnamon back in 2014 ([Cinnamon PR#3779](linuxmint/cinnamon#3779)). **#LookingGlassDialog** was kept because it's still used by Melange. But the styling of elements *inside* this *ID* (**#Toolbar**, **StScrollBar**, etc.) were removed because it seems that they were also removed. - **.end-session-dialog-***, **.hotplug-*** and **.polkit-dialog-***: Everything related to these classes was removed from Cinnamon back in 2013 ([Cinnamon commit where these classes were removed from the default theme](linuxmint/cinnamon@b8d1dbb)). - **.popup-menu** and **.popup-menu-boxpointer**: These classes were left for retro-compatibility with Cinnamon versions under 3.2.x. But since version 3.4.x of Cinnamon, it is not possible to make this theme retro-compatible due to the removal of the programmatically added spacing on the **TextIconApplet** prototype by [Cinnamon PR#6271](linuxmint/cinnamon#6271). I also checked the applets repository, and none of the applets are using these classes anymore. **Classes kept if the theme is built for Cinnamon version 3.0.x.** - **.menu-category-button-button:hover**: This selector's class never existed. And even if it is a typo meant to style the **menu-category-button-selected** class on hover, its result is horrendous. So, I removed it. - **#overview-corner**: The hot corner icons were removed by [Cinnamon PR#6423](linuxmint/cinnamon#6423). The images **overview.png** and **overview-hover.png** were also removed. - **.panel-button** and **.panel-menu**: This classes usage was removed in this [Cinnamon commit](linuxmint/cinnamon@91b0b76). - The third-party xlet called **Weather** defines the **panel-button** class to be used for styling, [but never really uses it](https://github.com/linuxmint/cinnamon-spices-applets/blob/master/weather%40mockturtl/files/weather%40mockturtl/applet.js#L123). - The third-party applet called **CPU Frequency Applet** uses the **panel-button** class [but then it removes it](https://github.com/linuxmint/cinnamon-spices-applets/blob/master/cpufreq%40mtwebster/files/cpufreq%40mtwebster/applet.js#L150). - **.panel-status-button**: Hard to pin-point were this class was removed. My guess is around [Cinnamon PR#4125](linuxmint/cinnamon#4125). What's easy to realize is that the styles defined in this class are almost the same as the styling for the **applet-box** class. Additionally, the **-natural-hpadding** and **-minimum-hpadding** properties defined in this class are never programmatically applied. - Class used by the default applet called **Keyboard** (UUID keyboard@cinnamon.org). I think that this class should be removed from this applet. - **.label-shadow**: This class is defined by the **TextShadower** prototype. This prototype hasn't been used in Cinnamon [since around 2012](linuxmint/cinnamon@3f25240) and, if it is usefull to know, it was removed from Gnome Shell [in 2015](333becef45d58be20ea0b9d4404c2c382a9db117). I removed it because [of the comment in this prototype's definition](https://github.com/linuxmint/Cinnamon/blob/master/js/ui/panel.js#L1201), which suggests that the prototype might get removed in case of it not been used anymore (my guess). - Removed `opacity` and `mouseover-opacity` properties from **#notification** selector. These properties were used before the **Have notifications fade out when hovered over** setting was introduced ([Cinnamon commit](linuxmint/cinnamon@dae0a21)). Now a days, neither of the properties are used programmatically nor the aforementioned setting exist.
Odyseus
added a commit
to Odyseus/mint-themes
that referenced
this pull request
Mar 30, 2018
These classes/IDs/properties were removed because they aren't used anymore by any version of Cinnamon that this theme supports. - **.lg-*** and **#LookingGlassPropertyInspector**: Everything related to these classes and *ID* was removed from Cinnamon back in 2014 ([Cinnamon PR#3779](linuxmint/cinnamon#3779)). **#LookingGlassDialog** was kept because it's still used by Melange. But the styling of elements *inside* this *ID* (**#Toolbar**, **StScrollBar**, etc.) were removed because it seems that they were also removed. - **.end-session-dialog-***, **.hotplug-*** and **.polkit-dialog-***: Everything related to these classes was removed from Cinnamon back in 2013 ([Cinnamon commit where these classes were removed from the default theme](linuxmint/cinnamon@b8d1dbb)). - **.popup-menu** and **.popup-menu-boxpointer**: These classes were left for retro-compatibility with Cinnamon versions under 3.2.x. But since version 3.4.x of Cinnamon, it is not possible to make this theme retro-compatible due to the removal of the programmatically added spacing on the **TextIconApplet** prototype by [Cinnamon PR#6271](linuxmint/cinnamon#6271). I also checked the applets repository, and none of the applets are using these classes anymore. - **.menu-category-button-button:hover**: This selector's class never existed. And even if it is a typo meant to style the **menu-category-button-selected** class on hover, its result is horrendous. So, I removed it. - **#overview-corner**: The hot corner icons were removed by [Cinnamon PR#6423](linuxmint/cinnamon#6423). The images **overview.png** and **overview-hover.png** were also removed. - **.panel-button** and **.panel-menu**: This classes usage was removed in this [Cinnamon commit](linuxmint/cinnamon@91b0b76). - The third-party xlet called **Weather** defines the **panel-button** class to be used for styling, [but never really uses it](https://github.com/linuxmint/cinnamon-spices-applets/blob/master/weather%40mockturtl/files/weather%40mockturtl/applet.js#L123). - The third-party applet called **CPU Frequency Applet** uses the **panel-button** class [but then it removes it](https://github.com/linuxmint/cinnamon-spices-applets/blob/master/cpufreq%40mtwebster/files/cpufreq%40mtwebster/applet.js#L150). - **.panel-status-button**: Hard to pin-point were this class was removed. My guess is around [Cinnamon PR#4125](linuxmint/cinnamon#4125). What's easy to realize is that the styles defined in this class are almost the same as the styling for the **applet-box** class. Additionally, the **-natural-hpadding** and **-minimum-hpadding** properties defined in this class are never programmatically applied. - Class used by the default applet called **Keyboard** (UUID keyboard@cinnamon.org). I think that this class should be removed from this applet. - **.label-shadow**: This class is defined by the **TextShadower** prototype. This prototype hasn't been used in Cinnamon [since around 2012](linuxmint/cinnamon@3f25240) and, if it is usefull to know, it was removed from Gnome Shell [in 2015](333becef45d58be20ea0b9d4404c2c382a9db117). I removed it because [of the comment in this prototype's definition](https://github.com/linuxmint/Cinnamon/blob/master/js/ui/panel.js#L1201), which suggests that the prototype might get removed in case of it not been used anymore (my guess). - Removed `opacity` and `mouseover-opacity` properties from **#notification** selector. These properties were used before the **Have notifications fade out when hovered over** setting was introduced ([Cinnamon commit](linuxmint/cinnamon@dae0a21)). Now a days, neither of the properties are used programmatically nor the aforementioned setting exist.
JosephMcc
pushed a commit
to linuxmint/mint-themes
that referenced
this pull request
Mar 30, 2018
* Clean up unused styles These classes/IDs/properties were removed because they aren't used anymore by any version of Cinnamon that this theme supports. - **.lg-*** and **#LookingGlassPropertyInspector**: Everything related to these classes and *ID* was removed from Cinnamon back in 2014 ([Cinnamon PR#3779](linuxmint/cinnamon#3779)). **#LookingGlassDialog** was kept because it's still used by Melange. But the styling of elements *inside* this *ID* (**#Toolbar**, **StScrollBar**, etc.) were removed because it seems that they were also removed. - **.end-session-dialog-***, **.hotplug-*** and **.polkit-dialog-***: Everything related to these classes was removed from Cinnamon back in 2013 ([Cinnamon commit where these classes were removed from the default theme](linuxmint/cinnamon@b8d1dbb)). - **.popup-menu** and **.popup-menu-boxpointer**: These classes were left for retro-compatibility with Cinnamon versions under 3.2.x. But since version 3.4.x of Cinnamon, it is not possible to make this theme retro-compatible due to the removal of the programmatically added spacing on the **TextIconApplet** prototype by [Cinnamon PR#6271](linuxmint/cinnamon#6271). I also checked the applets repository, and none of the applets are using these classes anymore. - **.menu-category-button-button:hover**: This selector's class never existed. And even if it is a typo meant to style the **menu-category-button-selected** class on hover, its result is horrendous. So, I removed it. - **#overview-corner**: The hot corner icons were removed by [Cinnamon PR#6423](linuxmint/cinnamon#6423). The images **overview.png** and **overview-hover.png** were also removed. - **.panel-button** and **.panel-menu**: This classes usage was removed in this [Cinnamon commit](linuxmint/cinnamon@91b0b76). - The third-party xlet called **Weather** defines the **panel-button** class to be used for styling, [but never really uses it](https://github.com/linuxmint/cinnamon-spices-applets/blob/master/weather%40mockturtl/files/weather%40mockturtl/applet.js#L123). - The third-party applet called **CPU Frequency Applet** uses the **panel-button** class [but then it removes it](https://github.com/linuxmint/cinnamon-spices-applets/blob/master/cpufreq%40mtwebster/files/cpufreq%40mtwebster/applet.js#L150). - **.panel-status-button**: Hard to pin-point were this class was removed. My guess is around [Cinnamon PR#4125](linuxmint/cinnamon#4125). What's easy to realize is that the styles defined in this class are almost the same as the styling for the **applet-box** class. Additionally, the **-natural-hpadding** and **-minimum-hpadding** properties defined in this class are never programmatically applied. - Class used by the default applet called **Keyboard** (UUID keyboard@cinnamon.org). I think that this class should be removed from this applet. - **.label-shadow**: This class is defined by the **TextShadower** prototype. This prototype hasn't been used in Cinnamon [since around 2012](linuxmint/cinnamon@3f25240) and, if it is usefull to know, it was removed from Gnome Shell [in 2015](333becef45d58be20ea0b9d4404c2c382a9db117). I removed it because [of the comment in this prototype's definition](https://github.com/linuxmint/Cinnamon/blob/master/js/ui/panel.js#L1201), which suggests that the prototype might get removed in case of it not been used anymore (my guess). - Removed `opacity` and `mouseover-opacity` properties from **#notification** selector. These properties were used before the **Have notifications fade out when hovered over** setting was introduced ([Cinnamon commit](linuxmint/cinnamon@dae0a21)). Now a days, neither of the properties are used programmatically nor the aforementioned setting exist. * Fixed missing styles, duplicated properties and wrong references in comments - Added **url-highlighter** class styling: Links inside notifications weren't styled by the theme. They were hard-coded to **#ccccff**, which makes sense for the default theme with black backgrounds (the one called Cinnamon), but made these links practically unreadable on grey backgrounds like the Mint-X themes have. - Added support for the **progress** class. Class used by the overlay that display a progress indicator on the window list items. - Several entry selectors had the **selected-color** property declared twice. - Several comments that separate sections have a reference to the file that define the classes that are being styled. Some of those comments were wrong (they made reference to the file names from before the *default applets were converted into applets* (somewhere around this [Cinnamon commit](linuxmint/cinnamon@30d1c58))). For the sake of completeness, I also added references to the sections that didn't have them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Miscellaneous work on the looking glass. I should be separating them into separate pull requests but they will all be intertwined and probably won't merge nicely