panel-launchers: close the menu before destroying when removing launcher #5976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we destroy the menu while it is open then a callback set by pushModal removes the grab when it recieves the actor's destroy signal. Shortly after, we attempt to remove it again in popupMenu.js via the menu state change signal and fail. Closing the menu before destroying the actor avoids this issue. Fixes linuxmint#5968
I can reproduce this on LM 18 Cinnamon 2.8.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There may be a better/more correct fix for this. I'm not sure if this was introduced with the popupMenu.js changes or if it has existed for a while unnoticed.
If we destroy the menu while it is open then a callback set by pushModal removes
the grab when it recieves the actor's destroy signal. Shortly after, we attempt to
remove it again in popupMenu.js via the menu state change signal and fail. Closing
the menu before destroying the actor avoids this issue.
Fixes #5968