Notification styles

[ghost]

discussed in #233

It lacks a gui configuration because I'm not familiar with python in which cinnamon-settings written

upd: default setting doesn't change current behaviour

[AlbertJP]

@rat4 I could add the setting in cinnamon-settings, I see it's a gsettings key, what names should I give to options 0, 1, and 2? (think I'll probably make a dropdown box of it if that's OK)

[ghost]

@AlbertJP something like this:
0 = highlight window in panel
1 = bring window to front
2 = show notification popup

dropdown box is ok :-)

[AlbertJP]

@rat4 It took some time as the GSettingsComboBox wouldn't accept gsettings keys with type "i" - it expected a string. Or do you think we can better change the GSettings key into one of type "s" to keep the python code clean? Personally I prefer the latter as it's done that way everywhere in the code.

[ghost]

@AlbertJP It's not a problem, change as you need.

[AlbertJP]

@rat4 Please add me as a collaborator in your Cinnamon repo configuration, then I can commit it there. Then we can keep one pull request and don't need two that depend on each other. Also, I have already notified clem that this pull request can't yet be pulled.

[ghost]

Done

[AlbertJP]

@rat4 It seems like your work somehow breaks dropdown menus in Firefox.

[ghost]

@AlbertJP any examples?

[AlbertJP]

@rat4 The "firefox /" button which is displayed when the menu bar is not enabled, and live bookmarks such as the "News" one which is present by default

[ghost]

@AlbertJP See http://i.imgur.com/wIunS.png
What's wrong? (If I correctly understand)

[AlbertJP]

@rat4 It's probably a bug unrelated to your code which was fixed in master after notification_style branched off.

The menu does not appear at all when clicking "Firefox" but I can click on the invisible menu items.

[AlbertJP]

@rat4 Confirmed. This was a bug in Cinnamon master not related to your code. I think this code is ready to be pulled. (I haven't tested all the notification styles however, just made sure that cinnamon-settings sets the right thing in the GSettings key)

[AlbertJP]

@rat4 Do you think this is ready to be pulled?

[ghost]

@AlbertJP It's ready, if you have tested your changes.

[giesse]

Please merge this as Skype is completely unusable with Cinnamon otherwise!

[ceejatec]

ditto giesse. This makes Skype and QtCreator extremely annoying to use under Cinnamon. Please get into the next release.

[jkw]

Is this the bug that makes Skype steal focus anytime someone types a row in chat?

[AlbertJP]

@jkw This is not the bug, this is a pull request. The actual bug is #233.

[clefebvre]

A lot of work went into this so this is going to come as bad news. I should have reacted to it much earlier.

I don't like the idea of this being configurable.. mainly because this isn't a question of preference but a question of fixing a bug. The focus should always be taken when the user launches a new app and never be taken on his behalf when he doesn't trigger the creation of new content.

For Skype, I fixed the bug with this c5bbcad

For other apps which face a similar issue, I'd like people to insert the following code at line 27 in /usr/share/cinnamon/js/ui/windowAttentionHandler.js:

global.log_error("Focus stolen by : " + window.get_wm_class());

Then restart cinnamon, and when the focus is stolen from you, click on the ^ applet, troubleshoot, looking glass, click on the error tab, and you should see the wm class name of the app which stole your focus. Give me that wm class name, and we'll add it to Cinnamon.

[AlbertJP]

@clefebvre No problem, though I'd have liked to hear this earlier.

[giesse]

On Sat, Jun 9, 2012 at 3:46 PM, Clement Lefebvre
reply@reply.github.com
wrote:

For Skype, I fixed the bug with this c5bbcad

I must wonder though, how did Gnome 2 handle this? Did they have to
special case Skype and other apps as well?

If it's not just skype, wouldn't it make much more sense to have the
list of window classes in a configuration file? (No need for a UI, but
just let people fix things easily rather than having to wait for a new
release.)

[clefebvre]

I'm afraid the problem doesn't come from the showDesktop applet but from the WM itself (mutter/muffin)... because if you manually minimize Gimp, it should minimize its other windows as well.

Gimp is a bit of a special case because these windows aren't tightly related to the main Gimp window. For instance, if you have two main Gimp windows (i.e. if you open two images), you only have one set of Gimp utility windows... so I guess that's where muffin/mutter fail to see that these windows "belong" to the one you're minimizing, and so they just don't minimize them as well.

I think there's two problems here:

• The gimp implementation is confusing (not only for the WM but also for the user)
• The WM itself isn't smart enough and doesn't properly minimize applications... it only manages to minimize their main windows and some of the windows relating to them (not all, as underlined in this issue).

[ceejatec]

Clement, was your last comment on the wrong pull request?

[clefebvre]

Yes... it looks like I posted in the wrong place there :))