New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong tray icon color for some applications when indicator support is enabled #4883
Comments
I don't want to register my phone in telegram, and the transmission-qt have not support for indicator in ubuntu 14.04, if i can see what occurs, i can try to fix it, but i can not see anything... |
I would like to know where that yellow icon for telegram is coming from. I can't seem to find it anywhere. |
I've never seen Telegram use any other color than blue for the tray icon |
@JosephMcc i think the reason of the different icon color is the behaviour of select the desired icon with the nearest size of the display space. Apparently inside the pixmap array not all icons are similar. This occurs in this function: https://github.com/lestcape/Cinnamon/blob/031a6add37d04e913a47a97b06b741634bf788f3/js/ui/indicatorManager.js#L1114 I think some one that can use an app with this behavior can display all icons and see if there are a way the get always one with a good size, but taking some how in account that will need to be the correctly. |
Here another reason of what could happen: #4953 |
This commit probably will resolve the problem: lestcape@1bef2e4 |
cinnamon 3.0.7 Still has this issue. The alpha icon is the icon of my app. What I can say is that I use plain QSystemTrayIcon. It should have a blue gradient. QSystemTrayIcon needs a QIcon which means that it is fixed and therefore independant of themes, unless implemented that way. However the icons of all indicators (which are annoying btw; why the heck do we need app indicators? Scrubbing? pff!) dissapear. Restarting cinnamon does not help. I create the QIcon with a svg file. QIcon should take care of the pixmap rendering. Maybe this is relevant since telegram is Qt(5) too. As stated in #4805 Unity, KDE Plasma 5, GNOME Shell. I can confirm this for Gnome. Why not taking a glimpse into this projects? |
@ManuelSchneid3r There are an icon cache inside the current version of the indicator api. Also in oldest version of cinnamon there are an equivalent cache for icons inside Gio. In another hands, some indicators render a different icon but with the same name to inform about his internal state. As a result both factors mean that the first icon that was rendered will not be updated... And will be displayed always the previously one, also if the state of the app changed. In my opinion this is the cause of the different icon colour... You can test if what i say is true if you test the same with this pull: #4814 included. |
I can confirm, that with this pull: #4814 Transmission-qt in Ubuntu 16.04 show the correct icons. So, sure the patch will probably fix all icons problems of qt apps... |
@varlesh see why your icons are not in the size that you want: https://github.com/linuxmint/Cinnamon/blob/master/files/usr/share/cinnamon/applets/systray%40cinnamon.org/applet.js#L162 |
Who want, can test if the icons are displayed correctly here: https://github.com/lestcape/Systray-Indicator. Also any other bugs on indicators, i will try to fix all bugs that i can.... |
@nspacestd, is this still an issue for you in Cinnamon 3.6? |
Same as issue #4805, only it happens for other applications too, namely TeamSpeak 3 and Transmission-qt (Transmission-gtk is fine). All these applications use QT for their GUI.
This is how it looks with indicator support turned off
This is how it looks with indicator support enabled
Changing the icon theme doesn't seem to do anything (tested with Adwaita, Faenza and HighContrast)
My system runs up-to-date Arch linux with Cinnamon 2.8.5
The text was updated successfully, but these errors were encountered: