Skip to content
This repository has been archived by the owner on Jan 3, 2022. It is now read-only.

mint-themes: Artefacts on rounded corners #26

Closed
AwesamLinux opened this issue Dec 15, 2021 · 6 comments
Closed

mint-themes: Artefacts on rounded corners #26

AwesamLinux opened this issue Dec 15, 2021 · 6 comments

Comments

@AwesamLinux
Copy link

corner
(had to take photo with a camera, because problem disappears when taking a screenshot)

With the new rounded corners, black pixels on the edge of the corner intermittently appear (transparency issue I believe).

To replicate open up a few windows (on the example above I had three open), then click between the windows (to activate/bring them to front) and the problem may appear in one of the windows.

(I only tried this in the USB live environment with the Mesa drivers it came with, GPU is a RX5700)

@SebastJava
Copy link

Also showing there: #5 (comment)

@ghost
Copy link

ghost commented Dec 16, 2021

pixels

Can confirm the bug on both the left and right ends of the title bar but when zooming the screenshot, the pixels appear reddish. Bug affects applications with rounded top corners as illustrated above in the screenshot like nemo, xviewer, xreader, mintstick, gimp, inkscape when light theme is used. Dialog boxes like User Authentication and Session dialog, and applications with less rounded corners are not affected like Mint Welcome, Thingy, gnome applications like Gnome Disks and Gnome Logs, and Gimagereader as illustrated below:

dialog

less rounded

@clefebvre clefebvre changed the title Rounded corner transparency issue (black pixels) mint-themes: Artefacts on rounded corners Dec 16, 2021
@clefebvre
Copy link
Member

We can't fix it just yet unfortunately. It's an issue with metacity and the antialiasing in muffin/cinnamon. It was already an issue before, it's just more visible when the radius is higher.

We're working on a mutter rebase (hopefully landing in cinnamon 5.4 / mint 21) and with that we'll switch all windows to Gtk rendering and abandon metacity themes. This will solve this problem.

@Harry-W-Haines-III
Copy link

Harry-W-Haines-III commented Dec 16, 2021

Does this mean the end of official support for the Mint-X theme? Or this applies just to Mint-Y?

@clefebvre
Copy link
Member

Whether it's in Mint-Y, or Mint-X, or any theme... right now we're rendering titlebars in two different ways depending on the application:

  • If the app has no headerbar (an SSD window in other words), we give it a titlebar using the metacity theme, and a shadow (which isn't themeable).
  • If the app has a headerbar (a CSD window in other words), Gtk handles the headerbar and the shadow, and both are themed using the Gtk theme.

What we're hoping to do in the future is simply to use the Gtk theme to render SSD titlebars and shadows. This would make all windows have the exact same shadows, and corners/buttons. Right now they kinda look the same if you don't look at them too closely. This is for every theme.

The impact on themes is simply the loss of metacity themes and the inability to set titlebars to a different theme than Gtk controls.

You can test this with metacity if you want. Ironically, by default, metacity actually doesn't use metacity themes. It renders everything with the Gtk theme.

@LinuxOnTheDesktop
Copy link

It is unfortunate that Mint is implementing rounded corners before a fix for a problem with rounded corners is available. I am sorry to party-poop, but perhaps the implementation of the rounded corners should have been delayed.

Given this problem, I for one will be installing the legacy themes package straightaway. Or at least I will if the bug affects dark themes. Note also that Mint is liable to receive multiple reports of the problem.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

5 participants