Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Implement lock-screen/screensaver #68

Closed
Ste74 opened this issue Jul 20, 2017 · 15 comments
Closed

[Feature Request] Implement lock-screen/screensaver #68

Ste74 opened this issue Jul 20, 2017 · 15 comments

Comments

@Ste74
Copy link
Contributor

Ste74 commented Jul 20, 2017

Hi there , us ( Manjaro Linux ) and i think also @ikeydoherty ( Solus ) and @fossfreedom ( Ubuntu Budgie ) are interested at the screensaver implementation in order to drop the gnome legacy screensaver .. ( guys correct me if i wrong :p and sorry if mention you :p ) . In the source code i don't see this .. any plan to add this feature ?

Stefano Capitani
Manjaro Team

@ikeydoherty
Copy link
Contributor

I might be wrong but I think thats handled through light-locker?

@fossfreedom
Copy link
Contributor

I thought light-locker had ceased ... but I noticed a few commits lately. So still alive? I couldnt get it to work the last time I looked at it though (12+ months ago)

@ikeydoherty
Copy link
Contributor

I just had a play with it, and it refuses to run because of GSD's ScreensaverProxy, which can only be turned off with hacks (redirected .desktop files ...)

Hate to say it lads but we might just have to fork gnome-screensaver.

@Ste74
Copy link
Contributor Author

Ste74 commented Jul 20, 2017

I thought light-locker had ceased ... but I noticed a few commits lately. So still alive? I couldnt get it to work the last time I looked at it though (12+ months ago)

I just had a play with it, and it refuses to run because of GSD's ScreensaverProxy, which can only be turned off with hacks (redirected .desktop files ...)

Yep , i also did not get it to work for this I wondered how it could be implemented with slick-greeter: a matter of visual uniformity.

@mtwebster
Copy link
Member

I don't care one way or the other but we ported our old fork of gnome-screensaver to (mostly) python a while back, if you want yet another option to fork.. it doesn't use lightdm but it could be simpler to start with. Other than the name it's more or less DE-independent for now (though I have never tried it in a session where gsd was running).

@Ste74
Copy link
Contributor Author

Ste74 commented Jul 24, 2017

Hi , what do you mean with old fork ?

@ikeydoherty
Copy link
Contributor

I believe @mtwebster is talking about cinnamon screensaver. I remember reading about that, where it was claimed that porting it to Python made it faster than C - which you know I'm never going to buy. It's also not pure C if I recollect correctly, but it took the bulk of gnome-screensaver and converted it to an in-tree C library..

@JosephMcc
Copy link
Contributor

Not sure who made the claim that porting to Python made it faster somehow. In the case of the screensaver I'm not sure speed is really a large issue though.

@ikeydoherty
Copy link
Contributor

@JosephMcc you saying the Linux world has unreliable news coverage? :P

@JosephMcc
Copy link
Contributor

What!? No way... ;)

@mtwebster
Copy link
Member

The vast majority of it is in python, the remaining C is either autogenerated gdbus-codegen files for various services, or things that couldn't reliably be performed in python, either due to lack of python3 support for xlib on some distros, or GdkScreen behavior being at odds with the wm, among other things. The pam authentication stuff was also re-used (lightdm wasn't on our radar yet at that time.)

The main reason we did it was to get rid of growing problems like GtkPlug/GtkSocket rot and to make it a bit more accessible for maintenance and development. I wasn't trying to peddle our own wares here, I was just offering up an alternative to start with - I have no doubt you'd likely want to rip the entire ui out, but the plumbing is in, it connects to the proper things, etc...

@ikeydoherty
Copy link
Contributor

IDK the UI looks alright to me - and I whole heartedly agree with axing the GtkPlug/GtkSocket nonsense.

@Ste74
Copy link
Contributor Author

Ste74 commented Jul 24, 2017

@mtwebster so is possible do a cinnamon-screensaver Distro/DE agnostic? @ikeydoherty know me i'm not a programmer :p

@zachlovescoffee
Copy link

Not to be a jerk but it looks like the OP's question was never answered or resolved as you guys spun off into a who's right/wrong on C vs Python. I've just started using slick-greeter and it's awesome but the experience is really dragged down when Debian goes to lock screen and we're back to using the gnome default lock screen login prompt.

@clefebvre
Copy link
Member

Slick greeter is a lightdm greeter. Light-locker can lock your session and show your lightdm prompt instead of a screensaver. This has limitations though, you're no longer active on your session seat if that makes sense.. for instance you no longer have access to sound. I wouldn't recommend it if the DE has a decent screensaver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants