Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

microwatt probes serial ports twice #413

Open
shenki opened this issue May 30, 2022 · 0 comments
Open

microwatt probes serial ports twice #413

shenki opened this issue May 30, 2022 · 0 comments
Labels
bug It's a bug

Comments

@shenki
Copy link
Member

shenki commented May 30, 2022

The microwatt machine calls of_platform_default_populate in an arch_initcall, which causes it to probe some drivers twice:

[    1.185779] Serial: 8250/16550 driver, 4 ports, IRQ sharing disabled
[    1.212557] printk: console [ttyS0] disabled
[    1.245614] serial8250.0: ttyS0 at MMIO 0xc0002000 (irq = 16, base_baud = 6250000) is a 165A
[    1.275052] printk: console [ttyS0] enabled
[    1.283472] printk: bootconsole [udbg0] disabled
[    1.320930] printk: console [ttyS0] disabled
[    1.335603] c0002000.serial: ttyS0 at MMIO 0xc0002000 (irq = 16, base_baud = 6250000) is a 0
[    1.336024] printk: console [ttyS0] enabled

which doesn't cause any issues I've noticed, but it is unnecessary.

setup_arch calls find_legacy_serial_ports which causes the double registration. This function also does some of the console handling.

This is related to #404.

@shenki shenki added the bug It's a bug label May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug
Projects
Status: Stale
Development

No branches or pull requests

1 participant