Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Use more of upstream config.yaml #94

Closed
1 task done
RollingStar opened this issue Dec 26, 2022 · 7 comments
Closed
1 task done

[FEAT] Use more of upstream config.yaml #94

RollingStar opened this issue Dec 26, 2022 · 7 comments

Comments

@RollingStar
Copy link

Is this a new feature request?

  • I have searched the existing issues

Wanted change

There's a mismatch between the config here and the default beets config:

https://github.com/beetbox/beets/blob/master/beets/config_default.yaml

https://github.com/linuxserver/docker-beets/blob/master/root/defaults/config.yaml

Perhaps most critically is this part in upstream:

import:
write: yes
copy: yes
move: no

This means "copy all imported music to a new folder, and write new tags into the copied files, and leave the raw imported files alone", basically.

This repo has:
import:
write: yes
copy: no
move: yes

This is a source of confusion, with a popular YouTuber (Techno Dad Life) recommending a change from these defaults. https://youtu.be/IQGM52MiIqg?t=198

Is there a reason for this?

Reason for change

I can't find any commit where upstream has move:yes.

https://github.com/beetbox/beets/commits/master?after=cc7abe3a4734de73c86cb9ba6253c6a5596a042b+69&branch=master&path%5B%5D=beets&path%5B%5D=config_default.yaml&qualified_name=refs%2Fheads%2Fmaster

Proposed code change

No response

@github-actions
Copy link

Thanks for opening your first issue here! Be sure to follow the bug or feature issue templates!

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@RollingStar
Copy link
Author

thanks

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@RollingStar
Copy link
Author

cool

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 29, 2023
@github-actions
Copy link

This issue is locked due to inactivity

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant