Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you please update the dockerfile to check the architecture? #21

Closed
camelator opened this issue Mar 3, 2020 · 3 comments
Closed

Comments

@camelator
Copy link

I am not a dockerfile specialist,
but I can see in the dockerfile line 23:
CODE_RELEASE=$(curl -sX GET "https://api.github.com/repos/cdr/code-server/releases/latest"
Having a look on this repo, I can see there are builds per architecture.
But in line 27:
select(.browser_download_url | contains("linux-x86_64"))
I am not sure what this part do, but it looks like it uploads the x86_64 architecture file.
This is why the final image does not work on my ARM64 board.
Instead I just replace the linux-x86_64 by linux-arm64 and the image works perfectly on my nano Fire3 board.
I don't know how to do that, but is it possible to check the architecture of the machine and download the relevant file?

Thanks and regards,

@project-bot project-bot bot added this to To do in Issue & PR Tracker Mar 3, 2020
@aptalca
Copy link
Member

aptalca commented Mar 3, 2020

This dockerfile is what we use to build the x86_64 image. You'd need to modify it yourself to build for other platforms

@aptalca aptalca closed this as completed Mar 3, 2020
Issue & PR Tracker automation moved this from To do to Done Mar 3, 2020
@aptalca
Copy link
Member

aptalca commented May 21, 2020

@camelator this image is now multi-arch and supports amd64, arm32v7 and arm64v8
When you pull linuxserver/code-server it should get the right image for your arch

@camelator
Copy link
Author

Well... Many thanks
I'll try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants