Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDR HW Tone Mapping broken again #318

Closed
Rainzzzzzz opened this issue Jul 6, 2022 · 15 comments · Fixed by #319
Closed

HDR HW Tone Mapping broken again #318

Rainzzzzzz opened this issue Jul 6, 2022 · 15 comments · Fixed by #319

Comments

@Rainzzzzzz
Copy link

linuxserver.io


Expected Behavior

HDR Tone Mapping should still use hardware transcode

Current Behavior

When HDR tone mapping is enabled, software transcode is used

Steps to Reproduce

1.Add the /dev/dri device to the container
2.Enable HDR tone mapping
3.Play something with HDR and force it to transcode
4

Environment

Unraid 6.10.3
I5 11 gen
How docker service was installed:
Unraid app menu

Command used to create docker container (run/create/compose/screenshot)

Docker logs

@project-bot project-bot bot added this to To do in Issue & PR Tracker Jul 6, 2022
@github-actions
Copy link

github-actions bot commented Jul 6, 2022

Thanks for opening your first issue here! Be sure to follow the bug or feature issue templates!

Issue & PR Tracker automation moved this from To do to Done Jul 6, 2022
@Rainzzzzzz Rainzzzzzz reopened this Jul 6, 2022
Issue & PR Tracker automation moved this from Done to PRs & in progress issues Jul 6, 2022
@Rainzzzzzz
Copy link
Author

Close it by mistake

@Rainzzzzzz
Copy link
Author

All HDR transcode are software now
But non-HDR content goes to HW perfectly

@Rainzzzzzz
Copy link
Author

@aptalca
Copy link
Member

aptalca commented Jul 6, 2022

See here: #312

@duckyyyviewer
Copy link

duckyyyviewer commented Jul 7, 2022

Same for me until I reverted back to 1.27.1.5916-6b0e31a64-ls122

Edit:

On the plex forums they mention the following:
(Linux) Improve Intel Compute Runtime version detection in packaging on Ubuntu 22.04 and newer.

Maybe that has something to do with the problem. Even though I'm on Ubuntu 20.04.

Edit 2:
According to https://www.reddit.com/r/PleX/comments/vny30q/new_beta_pms_version_available_12725929a806c5905/ie9wh8b/ the intel change was not even included. So I have no clue what causes it to break.

@nickp85
Copy link

nickp85 commented Jul 9, 2022

Same issue, problem is back just like before. With tone mapping enabled, no HW transcode on HDR content. 9900K here. Turning off tone mapping fixes it

@Rainzzzzzz
Copy link
Author

Rainzzzzzz commented Jul 11, 2022

The only way is to revert to 1.27.1.5916-6b0e31a64-ls122 and lock it there
Work fine since the rollback

@ScottJWhite
Copy link

The only way is to revert to 1.27.1.5916-6b0e31a64-ls122 and lock it there Work fine since the rollback

This worked for me! My CPU was hurting bad.

@olqs
Copy link

olqs commented Jul 18, 2022

I have manually installed the intel compute-runtime packages: https://github.com/intel/compute-runtime/releases/tag/21.49.21786 inside the container and hw transcode with tone mapping is working again.

@aptalca
Copy link
Member

aptalca commented Jul 18, 2022

Can you guys test this build and let us know if it works? lspipepr/plex:amd64-1.27.2.5929-a806c5905-pkg-bbd93429-pr-319

@patrickthescriptwhisperer

Hey @aptalca, I too have the hw tone mapping issue which is resolved with the image linuxserver/plex:1.27.1.5916-6b0e31a64-ls122, allowing me to transcode or optimise 4k hdr video using hw acceleration on my intel core i7-1165G7. I tried your image lspipepr/plex:amd64-1.27.2.5929-a806c5905-pkg-bbd93429-pr-319 out on the same file with the same optimisation settings and see that it does not fix the issue, falling back to sw encoding. If you want more details let me know.

@aptalca
Copy link
Member

aptalca commented Jul 18, 2022

@patrickthescriptwhisperer can you repull that image and try again? I pushed an update

Thanks

@patrickthescriptwhisperer

sorry that took a minute, just wanted to double check the cpu usage between your latest and the original image I was tied to. The latest pull of your image appears to be working well 👍 the full transcode still takes a little while so I will leave it running and I can spot check the output when it completes. Thanks for putting that together.

Issue & PR Tracker automation moved this from PRs & in progress issues to Done Jul 18, 2022
@patrickthescriptwhisperer

tone mapping seemed to work well; no weird artefacts, no dimming, thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

7 participants