Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Circle Painter - Enhancement (draft) #476

Closed
1 task done
claws99 opened this issue Jul 31, 2023 · 7 comments
Closed
1 task done

[Enhancement]: Circle Painter - Enhancement (draft) #476

claws99 opened this issue Jul 31, 2023 · 7 comments
Assignees
Labels
enhancement Small enhancements to existing features

Comments

@claws99
Copy link

claws99 commented Jul 31, 2023

Is your feature request related to a problem? Please describe

What is currently being called Circle is technically an ellipse and its is extremely difficult to get a circle.

providing another painter for circle isnt desirable.

Drawing circle can became easy if we provide any method to constrain proportions (width = height)

Describe your feature request!

I'm thinking we can provide something like holding something else which indicate drawing.

Using keyboard:
(borrowing from Inkscape)

  • draw = ellipse
  • shift + draw = draw the ellipse with starting point as center
  • ctrl + draw = circle
  • ctrl + shift + draw = draw circle with starting point as center

Using touch:
?? I'll research a bit more.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@claws99 claws99 added the enhancement Small enhancements to existing features label Jul 31, 2023
@CodeDoctorDE
Copy link
Member

There i already a circle painter. You can find it under the shapes

@claws99
Copy link
Author

claws99 commented Jul 31, 2023

There i already a circle painter. You can find it under the shapes

yeah. I'm using it, its an enhancement proposal for the current circle painter.

@CodeDoctorDE
Copy link
Member

Hmm, the problem is: The aspect ratio is a property of the shape painter.
We can override this behavior when pressing shift or ctrl if you want.
I would like to have a similar behavior on mobile. It would be cool if there is a similar behavior on mobile devices

@claws99
Copy link
Author

claws99 commented Jul 31, 2023

I would like to have a similar behavior on mobile. It would be cool if there is a similar behavior on mobile devices

I'm with you on providing similar behavior. Providing similar behaviour is what makes app coherent.

Just to clarify my thinking, similar behavior shouldn't mean identical behaviour. As identical features in most of the cases won't be the optimal/best possible solutions on all device types. This is fundamentally because different devices have different input and output devices.

This just simply means:

  • For devices with touch input, optimizing app to be easily interactable using gestures
  • For devices with keyboard input, optimizing app to be easily interactable using keyboard keys.
  • etc

This is inline with #433

Example: Excalidraw is great to be used with mouse, but its a nightmare on smaller and touch&pen-input devices.

In short, the principle I'm referring to is "There's more than one way to do it," commonly known as TMTOWTDI,

@CodeDoctorDE
Copy link
Member

The circle behavior can be replicated when setting aspect ratio to one. But i don't think it's really user friendly on mobile

@claws99
Copy link
Author

claws99 commented Jul 31, 2023

Sure! your call :)

@CodeDoctorDE
Copy link
Member

Added in 2.0.0-beta.6
Recoded the shape painter.
The same system can be used in a new stamp painter (#stamp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Small enhancements to existing features
Projects
Archived in project
Development

No branches or pull requests

2 participants