Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: Use git as a syncing method #693

Closed
1 task done
rong-xiaoli opened this issue May 10, 2024 · 2 comments
Closed
1 task done

[Feature request]: Use git as a syncing method #693

rong-xiaoli opened this issue May 10, 2024 · 2 comments
Assignees
Labels
feature-request A request for a new feature

Comments

@rong-xiaoli
Copy link

Is your feature request related to a problem? Please describe

No response

Describe your feature request!

As I said, I suggest using git as a syncing method.
Which may act like pulling from a git repo for a period of time, and commit and push for another (maybe longer) period of time.
The idea comes from here, obsidian-git.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@rong-xiaoli rong-xiaoli added the feature-request A request for a new feature label May 10, 2024
@CodeDoctorDE
Copy link
Member

This could be a nice addition but I have two things that I want to say:

  • First: To add this, we need a git client. Why not using the git installed on the system? Because android doesn't allow this. Then we need to ship a big git client inside the app.
  • Second (even bigger): The current file format is zip. Zip cannot work really good with binary data since it doesn't allow showing exact line changes

I have currently no idea how to fix these two things. Feel free to answer here!

@rong-xiaoli
Copy link
Author

I can't answer these two questions immediately. I suggest remain the issue close as not planned before someone can come up with a new idea.

@rong-xiaoli rong-xiaoli closed this as not planned Won't fix, can't repro, duplicate, stale May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A request for a new feature
Projects
Archived in project
Development

No branches or pull requests

2 participants