Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add payment-method-nonce to Customer #159

Conversation

lquach
Copy link
Contributor

@lquach lquach commented May 31, 2017

To create a payment method along with a customer.
The Ruby documentation: https://developers.braintreepayments.com/reference/request/customer/create/ruby#customer-with-a-payment-method

To create a customer with a payment method
@leighmcculloch
Copy link
Contributor

@lquach: Thanks! Could you add a test to customer_integration_test.go that creates a customer using one of the fake nonces?

@leighmcculloch leighmcculloch added this to the v0.12.0 milestone May 31, 2017
@lquach
Copy link
Contributor Author

lquach commented May 31, 2017

Test added.

@leighmcculloch
Copy link
Contributor

Nice! Thank you!

@lquach
Copy link
Contributor Author

lquach commented May 31, 2017

@leighmcculloch thank you!

@leighmcculloch leighmcculloch merged commit 45fd01a into braintree-go:master May 31, 2017
@leighmcculloch
Copy link
Contributor

leighmcculloch commented May 31, 2017

Aside to this we should probably look at splitting Customer into Customer (the data returned) and CustomerRequest (the data sent when creating/updating) like we recently did to Transaction, since it now has PaymentMethodNonce which is only used when creating the customer and not in the response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants