Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about the spherical tracing #37

Open
Haian-Jin opened this issue Apr 16, 2022 · 1 comment
Open

Question about the spherical tracing #37

Haian-Jin opened this issue Apr 16, 2022 · 1 comment

Comments

@Haian-Jin
Copy link

Hi, thanks for your great work.
I am reading your codes and one thing confuses me.
For the spherical tracing part, accoring to the paper, it should find the first intersection point (which is also nearer) first and if it is not convergent, the algorithm will begin at the another intersection point, which is the farthest point.
However, when I read the codes, the start_point seems to be farther from the camera center than the end_points because the start_points choose the index 0 of "sphere_intersections_points" and the end_points choose index 1.
image
Because according to "get_sphere_intersection" function,
the index 0 stores (-under_sqrt - ray_cam_dot) and index 1 stores (under_sqrt - ray_cam_dot), which means the tensors on index 0 have larger absolute value.
So it seems that start_points will be farther than the end_points, which is comfusing.
Did I get anything wrong?

@lioryariv
Copy link
Owner

We apply sphere tracing from the two edges of the sphere intersections, where the closest to the camera is in index 0, and the farther is in 1. After applying 10 steps of sphere tracing, we check if index 0 converged and it intersects with the zero level set of the neural network.

Hope this is clearer now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants