Piecon.reset() doesn't restore original favicon

[tim-peterson]

I'd like to show the pie chart favicon to chart progress during a file upload but then revert to my site's original favicon when the upload is complete. Piecon.reset() just restores a partially filled pie chart when I call it when the file is done uploading.

How can I modify piecon.js such that Piecon.reset() can restore the original favicon on my site?

thanks,
tim

[lipka]

This is implemented.

What browser/version are you running on?

[tim-peterson]

hi @lipka, I'm using Chrome 20. Here's the html for my site's original favicon:

<link rel='shortcut icon' href='/assets/img/myLogo.png' type='image/png'>

maybe Piecon.reset() is not recognizing the mime-type and needs it to be this: type="image/x-icon"?

[tim-peterson]

@lipka any thoughts on whether i've specified the mime-type incorrectly?

[crdx]

If you look at the source, it's because of this line:

piecon/piecon.js

Line 56 in 064890d

if (typeof(links[i]) !== 'undefined' && links[i].getAttribute('rel') === 'icon') {

It's looking for rel="icon" but yours is shortcut icon. If you made yours just icon it would work.

[tim-peterson]

oh awesome, thanks for finding this, problem solved!