Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Tests for release 1.1.0 need testing #13

Closed
lipkau opened this issue Jul 14, 2015 · 4 comments
Closed

Unit Tests for release 1.1.0 need testing #13

lipkau opened this issue Jul 14, 2015 · 4 comments

Comments

@lipkau
Copy link
Owner

lipkau commented Jul 14, 2015

Hi Craig, could you adjust the unit tests?
I just reused the ones you submitted with #12 but I believe the changes from #7 invalidated them.

@craibuc
Copy link
Collaborator

craibuc commented Jul 14, 2015

By default, Pester expects the unit-test scripts to be located in the same directory as the thing (e.g. command) being tested. I adjusted the two, unit-test files to accommodate the separate directories; they are passing.

The integration test for the PsIni module, however, is failing:

  • The order of the sections is incorrect
  • Get-IniContent returns an OrderedDictionary instead of a Hashtable

I can tag as 1.1.1 and create a pull request, if you want.

@lipkau
Copy link
Owner Author

lipkau commented Jul 14, 2015

That would be great.
Thanks.

I am disappointed with that pester behavior.
Almost all repos I use (that are not PS) have the unit tests in .\tests\

@craibuc craibuc mentioned this issue Jul 14, 2015
@craibuc
Copy link
Collaborator

craibuc commented Jul 14, 2015

There still is an issue with Get-IniContent--it reverses the order of the keys and sections.

@lipkau
Copy link
Owner Author

lipkau commented Jul 14, 2015

I believe this can be closed with v 1.1.1 ( #15 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants