Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract away the concept of converting to/from INI format from that of reading/writing an INI file #47

Open
iCodeSometime opened this issue Apr 29, 2019 · 5 comments

Comments

@iCodeSometime
Copy link

iCodeSometime commented Apr 29, 2019

This library would be much more useful to me if we were to separate the concept of converting to/from ini format from reading/writing files - since really these are separate things.

I propose that we create the functions ConvertTo-Ini and ConvertFrom-Ini, which would match the existing powershell api for JSON, Csv, etc.
Out-IniFile and Get-IniContent should then be rewritten to use these new functions.

Pros:

  • More flexible
  • More consistent with similar existing PS functionality

Cons:

  • ???

I need this ability for my project and am working on this.
I'm happy to consider any feedback and send a PR if you agree this would be useful

@iCodeSometime iCodeSometime changed the title Abstract the concept of reading/writing an INI file away from reading/creating INI content Abstract the concept of reading/writing an INI file away from converting to/from INI format Apr 29, 2019
@iCodeSometime iCodeSometime changed the title Abstract the concept of reading/writing an INI file away from converting to/from INI format Abstract away the concept of converting to/from INI format from that of reading/writing an INI file Apr 29, 2019
@lipkau
Copy link
Owner

lipkau commented Apr 30, 2019

Fair point.
I will make a new major release renaming to Import- and Export- adding ConvertTo- and ConvertFrom-

@iCodeSometime
Copy link
Author

Thanks @lipkau!

I take that to mean you're uninterested in a PR for this?

@lipkau
Copy link
Owner

lipkau commented May 2, 2019

Well...
I do want to change quite a bit in the tests and CI pipeline.
I can push my current status to a branch, and if you are interested in help, it will be very welcome

@lipkau
Copy link
Owner

lipkau commented May 2, 2019

@iCodeSometime
Copy link
Author

Yeah, I'll take a look and see what I can do.

I really appreciate your enthusiasm about this proposal, it'll significantly increase the usefulness of this project for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants