Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not found ULR (stop char missing) #66

Closed
oxozle opened this issue Apr 4, 2020 · 3 comments
Closed

Not found ULR (stop char missing) #66

oxozle opened this issue Apr 4, 2020 · 3 comments

Comments

@oxozle
Copy link

oxozle commented Apr 4, 2020

If there is no valid left stop char and there is no space in string valid url not found.
Example string:
スマホの方はこちらをクリック➡https://line.me/R/ti/p/%40pnd3781y

@lipoja
Copy link
Owner

lipoja commented Apr 4, 2020

Thank you for your time and reporting this issue. I really appreciate it.
I am thinking about it and I am not sure how to solve it. Do you have any suggestion?

This library is not able to cover all possibilities. I am trying to make compromise in a lot of thinks which are set as default. However I am always thinking about usability and therefore urlextract class has methods such as set_stop_chars_left(). I know that every text (page) is different and user should know what text is parsing and what to expect. This library should provide you all necessary functions/methods to tune it to fit users needs.

@lipoja
Copy link
Owner

lipoja commented Oct 3, 2020

@oxozle Is it OK for you to use internal methods to set your own stop characters based on the page you are parsing?
I still did not came up with any general solution.

@lipoja
Copy link
Owner

lipoja commented Dec 8, 2020

@oxozle I do not have any reply for 2 months. I am closing this issue since I think method set_stop_chars_left() can be used to solve this issue.

Feel free to reopen it any time.

@lipoja lipoja closed this as completed Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants