Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate detection with spaces in name #6

Open
lipwei1808 opened this issue Nov 17, 2023 · 1 comment
Open

Duplicate detection with spaces in name #6

lipwei1808 opened this issue Nov 17, 2023 · 1 comment

Comments

@lipwei1808
Copy link
Owner

Description

Duplication detection is not optimised

Steps to reproduce

  1. Run add /n Jane Smith /e jane@email.com /p 12345678 /a 123 Main St /b 123456789 /jd 12/09/2023 /s 1000.00 /l 10
  2. Run add /n Jane Smith /e jane@email.com /p 12345678 /a 123 Main St /b 123456789 /jd 12/09/2023 /s 1000.00 /l 10
  3. Both commands will run successfully

Note the only difference in the 2 commands is the name field.

Expected behaviour

As the 2 people are most likely to the be the same person, the application should reject adding the 2nd command.

Actual behaviour

The application allows for 2 people with the same name but varying spaces within the name to be added.

Reason for severity

As the name field does trimming of whitespaces, there should be optimisation done to prevent duplicates through having spaces within the name as well. Since the name "Jane Smith" and "Jane Smith" are most likely the same person, there should be control done to prevent adding these 2 duplicate people with exactly the same fields.

Screenshot 2023-11-17 at 4.27.46 PM.png

@nus-se-script
Copy link

Your response not required for this bug as the team has accepted the bug as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants