Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make filters more dynamic #109

Closed
2 tasks
2e2a opened this issue Mar 15, 2017 · 1 comment
Closed
2 tasks

Make filters more dynamic #109

2e2a opened this issue Mar 15, 2017 · 1 comment
Labels
Dev: Refactor issues to be fixed with code refactor

Comments

@2e2a
Copy link
Contributor

2e2a commented Mar 15, 2017

Currently filters have two issues:

  • Allow dynamic choices for OrderingFilter (currently fixed by the RequestOrderingMixin)
  • Allow custom choices for more widget types, e.g. BooleanFilter, NumberFilter (currently fixed by overloading the widget init)
@2e2a 2e2a added the Dev: Refactor issues to be fixed with code refactor label Mar 15, 2017
@2e2a
Copy link
Contributor Author

2e2a commented Apr 25, 2017

Current approach seems sufficient for now. If refactoring will be needed, it will be done in core.

@2e2a 2e2a closed this as completed Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Dev: Refactor issues to be fixed with code refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@2e2a