comment count missing on react list

[CarolingerSeilchenspringer]

URL: https://meinberlin-dev.liqd.net/projekte/burgerhaushalt-3-phasen-testprojekt/?initialSlide=1&mode=list
user: any
expected behaviour: comment count is visible
behaviour: comment count is missing
important screensize:
device & browser:
Comment/Question:

Screenshot?

[fuzzylogic2000]

I think, the whole rating and comment count wasn't there when the vote button is shown? And we use different ways of determining what we show. :( So, this is likely an admin issue?

[CarolingerSeilchenspringer]

@fuzzylogic2000 I have the view also as member of a group. But you are right, they are not in the design for voting phase. As the comments are always displayed in proposal detail it make sense to show them also in voting? Let's keep the issue open and discuss again later.

[Rineee]

@fuzzylogic2000 I could change it now to always show the comment count, as far as I understood Caro that would be her preferred solution.. any objections to doing that from your side?

[fuzzylogic2000]

@fuzzylogic2000 I could change it now to always show the comment count, as far as I understood Caro that would be her preferred solution.. any objections to doing that from your side?

@Rineee But only if the voting phase isn't active and the button is shown, right?

Go for it, though!

[Rineee]

@fuzzylogic2000 Now Im confused.. no, I thought Caro meant to also show the comment count during voting phase, so actually always show it? At the moment we have

permissions['view_comment_count'] = (
            self.module.has_feature('comment', Proposal)
            and not has_feature_active(self.module, Proposal, 'vote')
        )

so I would remove the has_feature_active part?

[fuzzylogic2000]

@Rineee True, she says so in the issue. But I am still sure that we didn't want to change that. From the screenshot I thought that the button was there because she was admin and not because of the phase. But when she wrote the issue, it was also the voting phase for the given project. Soooooo, don't know.
I think, we should still do it the other way round and not show the rating when the voting phase is active. So add the last bit to the view_rating as well?! And if that was totally wrong, I will change it next time.

[Rineee]

@fuzzylogic2000 Now I am even more confused 🤯
I was going to remove the rating count entirely from 3 phase budgeting and only show support (during support phase and between support and voting). I talked to Caro the other day that we can ignore the 3 phase modules that still have rating phase instead of support phase (so they would be broken then, i.e. neither show support nor rating).
Comment count I thought would make sense to show always (as Caro wrote), but in your opinion we should not show it during voting still? Sorry, if I didnt get it 🙈

[fuzzylogic2000]

@Rineee Yes, I thought as we were checking for !is_voting_phase in the jsx-code before the changes for the supprt phase for the whole stats, that we shouldn't show the comment count when the voting phase is running.
But it does actaully make more sense to always show the comment count to not have the tile so different in different phases and @CarolingerSeilchenspringer does say so in the issue. So, go for it and always show it! Sorry, that I confused you!

[Rineee]

Okay thanks, and also sorry for bugging you!
I also think we did decide at some point that we didnt want to show the comment count during voting (why?), but also think now it makes more sense to actually show them.. so I'll change it and if that was wrong, we just change it back 😁