Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smaller builds #180

Merged
merged 2 commits into from May 15, 2019
Merged

Smaller builds #180

merged 2 commits into from May 15, 2019

Conversation

harshjv
Copy link
Member

@harshjv harshjv commented May 14, 2019

At this moment, we require babel-polyfill just for ledger libs, and with this pr, we only require it in Ledger Provider, hence, just including only once.

On top of this, absoluteRuntime is enabled so even regenerator runtime is added once.

For significant reduction in size, see ledger & build packages.

This also produces smaller Swap UI builds.

Before

15:58 $ ls -lah packages/*/dist/*.min.js
-rw-r--r--  1 harsh  wheel   232K May 14 15:56 packages/bitcoin-bitcoinjs-lib-swap-provider/dist/bitcoin-bitcoinjs-lib-swap-provider.min.js
-rw-r--r--  1 harsh  wheel   212K May 14 15:57 packages/bitcoin-bitcore-rpc-provider/dist/bitcoin-bitcore-rpc-provider.min.js
-rw-r--r--  1 harsh  wheel   111K May 14 15:56 packages/bitcoin-collateral-provider/dist/bitcoin-collateral-provider.min.js
-rw-r--r--  1 harsh  wheel   710K May 14 15:57 packages/bitcoin-ledger-provider/dist/bitcoin-ledger-provider.min.js
-rw-r--r--  1 harsh  wheel   1.6K May 14 15:56 packages/bitcoin-networks/dist/bitcoin-networks.min.js
-rw-r--r--  1 harsh  wheel   172K May 14 15:56 packages/bitcoin-rpc-provider/dist/bitcoin-rpc-provider.min.js
-rw-r--r--  1 harsh  wheel   128K May 14 15:56 packages/bitcoin-swap-provider/dist/bitcoin-swap-provider.min.js
-rw-r--r--  1 harsh  wheel    92K May 14 15:56 packages/bitcoin-utils/dist/bitcoin-utils.min.js
-rw-r--r--  1 harsh  wheel   1.5M May 14 15:58 packages/bundle/dist/bundle.min.js
-rw-r--r--  1 harsh  wheel   283K May 14 15:56 packages/client/dist/client.min.js
-rw-r--r--  1 harsh  wheel    89K May 14 15:56 packages/crypto/dist/crypto.min.js
-rw-r--r--  1 harsh  wheel   9.1K May 14 15:56 packages/debug/dist/debug.min.js
-rw-r--r--  1 harsh  wheel    89K May 14 15:56 packages/errors/dist/errors.min.js
-rw-r--r--  1 harsh  wheel   120K May 14 15:56 packages/ethereum-erc20-provider/dist/ethereum-erc20-provider.min.js
-rw-r--r--  1 harsh  wheel   108K May 14 15:56 packages/ethereum-erc20-swap-provider/dist/ethereum-erc20-swap-provider.min.js
-rw-r--r--  1 harsh  wheel   707K May 14 15:57 packages/ethereum-ledger-provider/dist/ethereum-ledger-provider.min.js
-rw-r--r--  1 harsh  wheel   155K May 14 15:57 packages/ethereum-metamask-provider/dist/ethereum-metamask-provider.min.js
-rw-r--r--  1 harsh  wheel   1.7K May 14 15:56 packages/ethereum-networks/dist/ethereum-networks.min.js
-rw-r--r--  1 harsh  wheel   170K May 14 15:57 packages/ethereum-rpc-provider/dist/ethereum-rpc-provider.min.js
-rw-r--r--  1 harsh  wheel   105K May 14 15:57 packages/ethereum-swap-provider/dist/ethereum-swap-provider.min.js
-rw-r--r--  1 harsh  wheel   3.9K May 14 15:56 packages/ethereum-utils/dist/ethereum-utils.min.js
-rw-r--r--  1 harsh  wheel   132K May 14 15:56 packages/jsonrpc-provider/dist/jsonrpc-provider.min.js
-rw-r--r--  1 harsh  wheel   369K May 14 15:57 packages/ledger-provider/dist/ledger-provider.min.js
-rw-r--r--  1 harsh  wheel   121K May 14 15:57 packages/metamask-provider/dist/metamask-provider.min.js
-rw-r--r--  1 harsh  wheel   1.8K May 14 15:56 packages/provider/dist/provider.min.js
-rw-r--r--  1 harsh  wheel   2.5K May 14 15:56 packages/schema/dist/schema.min.js
-rw-r--r--  1 harsh  wheel   2.9K May 14 15:56 packages/utils/dist/utils.min.js
-rw-r--r--  1 harsh  wheel   103K May 14 15:56 packages/wallet-provider/dist/wallet-provider.min.js

After

16:58 $ ls -lah packages/*/dist/*.min.js
-rw-r--r--  1 harsh  wheel   230K May 14 16:56 packages/bitcoin-bitcoinjs-lib-swap-provider/dist/bitcoin-bitcoinjs-lib-swap-provider.min.js
-rw-r--r--  1 harsh  wheel   202K May 14 16:56 packages/bitcoin-bitcore-rpc-provider/dist/bitcoin-bitcore-rpc-provider.min.js
-rw-r--r--  1 harsh  wheel   110K May 14 16:56 packages/bitcoin-collateral-provider/dist/bitcoin-collateral-provider.min.js
-rw-r--r--  1 harsh  wheel   535K May 14 16:56 packages/bitcoin-ledger-provider/dist/bitcoin-ledger-provider.min.js
-rw-r--r--  1 harsh  wheel   1.6K May 14 16:56 packages/bitcoin-networks/dist/bitcoin-networks.min.js
-rw-r--r--  1 harsh  wheel   169K May 14 16:56 packages/bitcoin-rpc-provider/dist/bitcoin-rpc-provider.min.js
-rw-r--r--  1 harsh  wheel   126K May 14 16:56 packages/bitcoin-swap-provider/dist/bitcoin-swap-provider.min.js
-rw-r--r--  1 harsh  wheel    91K May 14 16:56 packages/bitcoin-utils/dist/bitcoin-utils.min.js
-rw-r--r--  1 harsh  wheel   1.2M May 14 16:56 packages/bundle/dist/bundle.min.js
-rw-r--r--  1 harsh  wheel   283K May 14 16:56 packages/client/dist/client.min.js
-rw-r--r--  1 harsh  wheel    89K May 14 16:56 packages/crypto/dist/crypto.min.js
-rw-r--r--  1 harsh  wheel   9.1K May 14 16:56 packages/debug/dist/debug.min.js
-rw-r--r--  1 harsh  wheel    88K May 14 16:56 packages/errors/dist/errors.min.js
-rw-r--r--  1 harsh  wheel   118K May 14 16:56 packages/ethereum-erc20-provider/dist/ethereum-erc20-provider.min.js
-rw-r--r--  1 harsh  wheel   106K May 14 16:56 packages/ethereum-erc20-swap-provider/dist/ethereum-erc20-swap-provider.min.js
-rw-r--r--  1 harsh  wheel   531K May 14 16:56 packages/ethereum-ledger-provider/dist/ethereum-ledger-provider.min.js
-rw-r--r--  1 harsh  wheel   138K May 14 16:56 packages/ethereum-metamask-provider/dist/ethereum-metamask-provider.min.js
-rw-r--r--  1 harsh  wheel   1.7K May 14 16:56 packages/ethereum-networks/dist/ethereum-networks.min.js
-rw-r--r--  1 harsh  wheel   166K May 14 16:56 packages/ethereum-rpc-provider/dist/ethereum-rpc-provider.min.js
-rw-r--r--  1 harsh  wheel   103K May 14 16:56 packages/ethereum-swap-provider/dist/ethereum-swap-provider.min.js
-rw-r--r--  1 harsh  wheel   3.4K May 14 16:56 packages/ethereum-utils/dist/ethereum-utils.min.js
-rw-r--r--  1 harsh  wheel   130K May 14 16:56 packages/jsonrpc-provider/dist/jsonrpc-provider.min.js
-rw-r--r--  1 harsh  wheel   284K May 14 16:56 packages/ledger-provider/dist/ledger-provider.min.js
-rw-r--r--  1 harsh  wheel   112K May 14 16:56 packages/metamask-provider/dist/metamask-provider.min.js
-rw-r--r--  1 harsh  wheel   1.8K May 14 16:56 packages/provider/dist/provider.min.js
-rw-r--r--  1 harsh  wheel   2.5K May 14 16:56 packages/schema/dist/schema.min.js
-rw-r--r--  1 harsh  wheel   2.8K May 14 16:56 packages/utils/dist/utils.min.js
-rw-r--r--  1 harsh  wheel   101K May 14 16:56 packages/wallet-provider/dist/wallet-provider.min.js

@harshjv harshjv changed the title Smaller build Smaller builds May 14, 2019
@harshjv harshjv merged commit 1450df9 into dev May 15, 2019
@kraikov kraikov deleted the smaller-build branch April 29, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant