Fix sendTransaction in ERC20 provider #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monokh
reviewed
May 15, 2019
| @@ -4,8 +4,8 @@ import { BigNumber } from 'bignumber.js' | |||
| import Provider from '@liquality/provider' | |||
| import { padHexStart } from '@liquality/crypto' | |||
| import { | |||
| ensureAddressStandardFormat, | |||
| ensureHexEthFormat | |||
| toLowerCaseWithout0x, | |||
There was a problem hiding this comment.
Yea this is kind of what I meant when i said the naming might start to mean more than just the 0x 😄
I hope we don't start to have sentences describing what a function does eventually... This is why calling it just standard or normalised is a better naming in my opinion.
monokh
reviewed
May 15, 2019
| ensureAddressStandardFormat, | ||
| ensureHexEthFormat | ||
| toLowerCaseWithout0x, | ||
| ensure0x |
There was a problem hiding this comment.
Note that eventually this might not even be just 0x, but also [EIP-55] (https://github.com/ethereum/EIPs/blob/master/EIPS/eip-55.md) in which case we need to update these names again. Just another reason i think giving it a name rather than describing it is better
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sendTransactionin ERC20 provider