Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eth findClaimSwapTransaction #259

Merged
merged 2 commits into from Apr 28, 2020
Merged

Fix eth findClaimSwapTransaction #259

merged 2 commits into from Apr 28, 2020

Conversation

harshjv
Copy link
Member

@harshjv harshjv commented Apr 27, 2020 •
edited

No description provided.

@harshjv harshjv requested a review from monokh April 27, 2020 13:41
@harshjv harshjv changed the title Fix eth findClaimSwapTransaction [WIP] Fix eth findClaimSwapTransaction Apr 27, 2020
@monokh
Copy link
Collaborator

monokh commented Apr 27, 2020 •
edited

Can we also add for the error for tx receipt not found in refund while we are here. That scenario will not be hit, but it will be consistent

@harshjv harshjv changed the title [WIP] Fix eth findClaimSwapTransaction Fix eth findClaimSwapTransaction Apr 28, 2020
@harshjv harshjv merged commit 56439f5 into dev Apr 28, 2020
@kraikov kraikov deleted the fix-eth-findClaimSwapTransaction branch April 29, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr0kchain gr0kchain gr0kchain approved these changes

@monokh monokh Awaiting requested review from monokh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@harshjv @monokh @gr0kchain