Add Bitcoin RPC provider #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshjv
requested review from
matthewjablack and
i3wgnit
and removed request for
i3wgnit
src/Client.js
Outdated
| async isUsedAddress (address) { | ||
| const isUsed = await this.getMethod('isUsedAddress')(address) | ||
|
|
||
| return isUsed |
There was a problem hiding this comment.
Can simplify this to
return this.getMethod('isUsedAddress')(address)
|
|
||
| import Transport from '@ledgerhq/hw-transport-node-hid' | ||
|
|
||
| export default class LedgerProvider extends Provider { |
matthewjablack
force-pushed
the
add-bitcoin-rpc
branch
from
4873d96
to
9884bcc
Compare
harshjv
force-pushed
the
add-bitcoin-rpc
branch
2 times, most recently
from
14da4b4
to
536333e
Compare
matthewjablack
force-pushed
the
add-bitcoin-rpc
branch
from
536333e
to
3d1d990
Compare
matthewjablack
force-pushed
the
add-bitcoin-rpc
branch
from
d096738
to
d8a4f41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes API/RPC methods from Hardware provider and simplifies Bitcoin transaction signing. Fixes #53, #54, #55
AddressBitcoinLedgerProviderisUsedAddressmethod onClientLedgerProvidermaster