Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce alias to <sqlCheck> #146

Closed
fbiville opened this issue Feb 24, 2022 · 3 comments
Closed

Introduce alias to <sqlCheck> #146

fbiville opened this issue Feb 24, 2022 · 3 comments
Assignees
@clarenced
Labels
good first issue Good for newcomers

Comments

@fbiville
Copy link
Collaborator

fbiville commented Feb 24, 2022 •
edited

This should be fairly similar to what's been done with the <cypher> alias to <sql> (see the CypherChange class).

Here, the idea would be to subclass liquibase.precondition.core.SqlPrecondition in the precondition package of the plugin, and just override public String getName() to return "cypherCheck".

This new subclass must be declared in the META-INF/services/liquibase.precondition.Precondition file.
@fbiville fbiville added the good first issue Good for newcomers label Mar 9, 2022
@clarenced
Copy link
Contributor

clarenced commented Mar 16, 2022 •
edited

I want to work on this issue.

@fbiville
Copy link
Collaborator Author

Perfect, let me know if you need any help!

@clarenced
Copy link
Contributor

Is the alias is sqlCheck or cypherCheck ?

@clarenced clarenced mentioned this issue Mar 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clarenced clarenced

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fbiville @clarenced