-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kraken230 firmware 2 image support #692
base: main
Are you sure you want to change the base?
Conversation
Set image sending twice to avoid no change after USB device initialization
So I wrote the solution to send the image to the AIO LCD. The manufacturer software sends it twice too. BTW I don't know why the commits went from my second account that I don't use :), probably git config thing |
Also:
Thanks! |
I added potential fix for |
Anything else I need to do? |
@aleksamagicka @jonasmalacofilho please tell me what I need to do to merge this change? |
I don't know if I'm supposed to do that, but I checked all items in the task, since LGTM received. |
No need to select things that are not applicable to your PR, for example, updating the man pages if it's not needed (and I don't think it is, here). |
docs/kraken-x3-z3-guide.md
Outdated
@@ -172,6 +172,8 @@ _New in git._<br> | |||
|
|||
Adds support for NZXT Kraken 2023 Standard, Elite | |||
|
|||
*For firmware version 2 gif screen mode is no longer supported* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe link the issue #631 here, and do say that this only applies to 2023 models.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you link issues? just hashtag in code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, something like *On 2023 models (standard and Elite), GIF screen mode is no longer supported for firmware versions 2.X (see #631).*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, wait, I think the syntax is different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I copied this already, and it's linked
I can change it of course
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works:
*On 2023 models (standard and Elite), GIF screen mode is no longer supported for firmware versions 2.X (see [#631][`issue-631`]).*
With this at the end of the file (it already has a reference to liquidtux there, so below that):
[`issue-631`]: https://github.com/liquidctl/liquidctl/issues/631
Sorry, I forgot that it doesn't automatically do that for md files.
Well, I copied this already, and it's linked
In the PR view it is, but not when you access the file normally.
So edit PR and remove items now? |
I don't think there's a hard and fast rule... I just leave them unchecked if they do not apply. |
Is this waiting for the comment on line 205 of the md guide to be removed, or trying to find a solution to the double image send? Looking forward to this getting merged to main 🙏 |
I think we are waiting for @jonasmalacofilho review? |
Added ability to set images for Kraken with firmware version 2
Fixes: #631
Closes:
Related:
Checklist:
docs/*guide.md
device guides, with "new/changed in" notesliquidctl.8
Linux/Unix/Mac OS man pagedocs/developer/protocol