-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add option to set cookies before visiting loginUrl #122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
This is awesome. Thank you Pascal 🙌 |
🎉 This PR is included in version 1.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@lirantal that was fast! Thank you - I just upgraded to v1.14.0 in our cypress project, added the Thanks for this Plugin, helps us ship our work with confidence! |
That's awesome @Pascalmh, thanks for sharing, and I'm happy here to help support it :) Curious - are you actually running it on CI or just on local dev machines? there has been some issues with social connecting providers due to the captcha and rigorous mitigations if you just try to sign-in from a new IP. |
Yes, we run it on CI - but only once a day, we use the |
Thanks. How do you pass through the 2FA part? or is that why you have the pre-visit cookie pull request? :) |
We use the |
Ahh got it. Thanks! |
Description
Types of changes
Related Issue
Motivation and Context
We needed to set a cookie so our feature(toggle) was enabled and the social login could be done as expected
How Has This Been Tested?
I tested it locally with my actual cypress project
Checklist: