Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #136

Merged
merged 1 commit into from
May 12, 2023
Merged

Update README.md #136

merged 1 commit into from
May 12, 2023

Conversation

FredLavoie
Copy link
Contributor

Description

There was a typo in a parameter. I noticed it when Cypress gave me an error from copying and pasting those parameters into my code.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • I have updated the documentation (if required).
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I added a picture of a cute animal cause it's fun

There was a typo in a parameter. I noticed it when Cypress gave me an error from copying and pasting those parameters into my code.
@lirantal lirantal self-requested a review May 12, 2023 17:39
@lirantal lirantal added the bug Something isn't working label May 12, 2023
@lirantal
Copy link
Owner

Life-saver. Thank you @FredLavoie ❤️

Copy link
Owner

@lirantal lirantal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lirantal lirantal merged commit 424070a into lirantal:master May 12, 2023
@github-actions
Copy link

🎉 This PR is included in version 1.14.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants