-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change ssd to lsd in README example #45
Conversation
@lirantal localStorage isn't persisting between tests using this approach, however utilizing the Cypress localStorage plugin (https://www.npmjs.com/package/cypress-localstorage-commands) works wonderfully:
Want me to add an addendum to the README with this plugin information and how to use in an example (I can clean up the above to remove unnecessary lines)? |
@@ -63,7 +63,7 @@ return cy.task('GoogleSocialLogin', socialLoginOptions).then(({cookies,lsd,ssd}) | |||
|
|||
cy.window().then(window => { | |||
Object.keys(ssd).forEach(key => window.sessionStorage.setItem(key, ssd[key])); | |||
Object.keys(lsd).forEach(key => window.sessionStorage.setItem(key, ssd[key])); | |||
Object.keys(lsd).forEach(key => window.localStorage.setItem(key, lsd[key])); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh wow, great catch!
as my friend @shaninja says: 🦅👁 ;-)
@wadehammes as for the comment on #45 (comment) - sure I'd love it if you wanted to send in another PR to update the README with that doc entry, thank you for proposing! 🤗❤️ |
🎉 This PR is included in version 1.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Update README to fix miscalled
ssd
tolsd
.