Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for GitHub and Microsoft social logins #53

Merged
merged 2 commits into from
Sep 4, 2020
Merged

feat: add support for GitHub and Microsoft social logins #53

merged 2 commits into from
Sep 4, 2020

Conversation

vikmaksymenko
Copy link
Contributor

Added support of GitHub and Microsoft

Refactor Plugins.js to handle multiple social logins

Description

Updated Plugins.js and added support of GitHub and Microsoft sign in

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Related Issue

#52

Motivation and Context

Needed GitHub and Microsoft support for testing the app.

How Has This Been Tested?

Was using it in testing project

Checklist:

  • I have updated the documentation (if required).
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I added a picture of a cute animal cause it's fun

@vikmaksymenko
feat: refactor Plugins.js to handle multiple social logins
83059a0 
Added support of GitHub and Microsoft
@vikmaksymenko
docs($readme): added info about GitHub and Microsoft support
7382e16 
Updated README.md  with info about GitHub and Microsoft support

no breaking changes
@lirantal lirantal self-requested a review September 1, 2020 06:13
@lirantal lirantal added the enhancement New feature or request label Sep 1, 2020
@lirantal
Copy link
Owner

lirantal commented Sep 1, 2020

Thanks @vikmaksimenko, I'll set some time to review and test later today/tomorrow.

lirantal
lirantal approved these changes Sep 4, 2020
View reviewed changes
Copy link
Owner

@lirantal lirantal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the Google and GitHub logins, looks great! 🚀

@lirantal
Copy link
Owner

lirantal commented Sep 4, 2020

Thanks @vikmaksimenko ❤️❤️❤️

@lirantal lirantal merged commit d3ea3e5 into lirantal:master Sep 4, 2020
@lirantal lirantal changed the title feat: refactor Plugins.js to handle multiple social logins feat: add support for GitHub and Microsoft social logins Sep 4, 2020
@lirantal lirantal mentioned this pull request Sep 4, 2020
Closed
@lirantal
Copy link
Owner

lirantal commented Sep 4, 2020

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@clatkar-spurqlabs
Copy link

clatkar-spurqlabs commented Nov 8, 2022 •
edited

try this recipe for SSO with MFA for Office 365 :-https://spurqlabs.com/login-to-o365-sso-enabled-application-with-mfa-using-cypress-10/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lirantal lirantal lirantal approved these changes

Assignees

@vikmaksymenko vikmaksymenko

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vikmaksymenko @lirantal @clatkar-spurqlabs