-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
publishing doesn't seem to work anymore #129
Comments
Yep, I'm on it. Looks like lockfile issues:
|
lockfile issues in a lockfile linter. classic. 😅 |
BTW, looks like the changes rolled out as a non-major version. Might be worth looking into why that happened if you have the time. |
Oh, that's not good. Can you remove them manually? I'll try running the steps locally and see what went wrong. |
@lirantal Tested locally and it worked as expected
Looks like a glitch. No idea how that's different |
Will be taking a look there |
I think maybe because in the prior publish run, it happened to create a git tag (b4a8143) for the two packages (although it wrongly created them as patch versions too). I think it didn't run through these because it thought them to be "released" already since the tag was created. |
I'm not convinced. I think the versions are established before it gets to checking any tags. Hypothesis: Somehow it didn't see the long commit messages in CI and locally it did. If logic was broken, someone would have noticed it before. |
Maybe. There were prior cases of major version changes, we can try and track back the commits/PRs. |
I looked at the generated changelog because something didn't add up - it doesn't seem to have taken into account any of my changes when creating the changelog. Maybe if it fails to include them after it has failed on them before? Maybe a rebase (squash your fix on top of my merge and remove publish) would help re-run? You;d still need to manually deprecate the current release for semver sake. Or I could add a bit of readme about lockfile-lint-api input options and duplicate the entry about breaking changes... |
Publishing task fails
https://github.com/lirantal/lockfile-lint/runs/6845308617?check_suite_focus=true
Seems like yarn no longer supports some of it.
The text was updated successfully, but these errors were encountered: