Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

axios 0.19 is vulnerable #116

Closed
nothingismagick opened this issue Dec 4, 2019 · 8 comments
Closed

axios 0.19 is vulnerable #116

nothingismagick opened this issue Dec 4, 2019 · 8 comments
Assignees
Labels

Comments

@nothingismagick
Copy link
Contributor

The bug that 0.19 sought to resolve introduced other errors. You can continue to use it the way you are doing - but it's safer to pin to =0.18.1.

  "dependencies": {
    "axios": "0.18.1",
@lirantal
Copy link
Owner

lirantal commented Dec 4, 2019

@nothingismagick can you confirm which errors it is introducing and whether npq is affected by this?

@lirantal lirantal self-assigned this Dec 4, 2019
@lirantal lirantal added the bug label Dec 4, 2019
@nothingismagick
Copy link
Contributor Author

npq IS NOT technically affected as far as I can tell - otherwise I would never have posted it here. The error that MIGHT happen is if you start to actually predefine axios and then consume it later.

@nothingismagick
Copy link
Contributor Author

The thing is that 0.19 was rushed out the door without real testing and tons of beta / alpha quality code was shipped - which broke a number of interfaces. This has been widely known for about 6 months.

@lirantal
Copy link
Owner

lirantal commented Dec 4, 2019

I see. Is there any benefit then in pinning it down if it doesn't affect us?

@nothingismagick
Copy link
Contributor Author

I don't know what your plans are - but my concern is that there may be other as yet undiscovered vulnerabilities lying in wait. 0.18.1 ONLY fixed the vulnerability about evil remotes not hanging up.

@lirantal
Copy link
Owner

lirantal commented Dec 4, 2019

I would leave as is unless we see something specific

@nothingismagick
Copy link
Contributor Author

Okey dokey.

@lirantal
Copy link
Owner

lirantal commented Dec 4, 2019

Nonetheless, appreciate the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants