Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm scripts): fix path in commitizen config #4

Merged
merged 1 commit into from Feb 1, 2019
Merged

fix(npm scripts): fix path in commitizen config #4

merged 1 commit into from Feb 1, 2019

Conversation

zacanger
Copy link
Contributor

@zacanger zacanger commented Jan 31, 2019

Fixes /app/node_modules to just /node_modules

Description

Fixes issue mentioned in #3

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Related Issue

#3

Motivation and Context

How Has This Been Tested?

This commit is the test.

Screenshots (if appropriate):

image

Checklist:

  • I have updated the documentation (if required).
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I added a picture of a cute animal cause it's fun

Fixes /app/node_modules to just /node_modules
@codecov-io
Copy link

codecov-io commented Jan 31, 2019

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #4   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          17     17           
  Branches        1      1           
=====================================
  Hits           17     17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c94ebbb...4d7f651. Read the comment docs.

@lirantal
Copy link
Owner

lirantal commented Feb 1, 2019

Great catch!
Can you make a similar PR to https://github.com/lirantal/create-node-lib/blob/master/template/package.json#L105 and https://github.com/lirantal/create-node-lib/blob/master/package.json#L126 which is the generator I use for my projects ?

@zacanger
Copy link
Contributor Author

zacanger commented Feb 1, 2019

Sure thing! lirantal/create-node-lib#7

@lirantal lirantal added the bug Something isn't working label Feb 1, 2019
@lirantal
Copy link
Owner

lirantal commented Feb 1, 2019

thanks!

@lirantal lirantal merged commit fa2c649 into lirantal:master Feb 1, 2019
@lirantal
Copy link
Owner

lirantal commented Feb 1, 2019

🎉 This PR is included in version 1.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@zacanger zacanger deleted the bug/commits branch February 1, 2019 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants