feat(short-text):add new field type #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there aren't 'option 1' and 'option 2 in list allowed answers and question 4 can't allowed other choice remove conditional construct from fetchformresponses(form.js) because when script get correct json it doesn't go there
short-text is open-ended question update fetchformresponses and add this type in whitelist in form.js add short-text in adapter update tests to this update close lirantal#8
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
==========================================
+ Coverage 96.42% 96.52% +0.09%
==========================================
Files 6 6
Lines 140 144 +4
Branches 24 24
==========================================
+ Hits 135 139 +4
Misses 5 5
Continue to review full report at Codecov.
|
|
awesome work @arszh ❤️✨ |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added short-text type of question. It is open-ended question.
Updated fetchFormResponses and added this type in whitelist in form.js
added short-text in adapters
updated snapshot to this update
Fixed formResponsesResult.json before adding short-text because there was inaccuracy and it made conflict with short-text in testing. Question 4 doesn't has 'option 1' and 'option 2 in list allowed answers and can't has other choice other than expected.
Also update Readme. Moved short_text from unsupported to supported.
It works with typeform-export-excel
Types of changes
Related Issue
#8
Motivation and Context
Extends the number of types of questions
How Has This Been Tested?
Data from typeform and snapshot
Screenshots (if appropriate):
Checklist: