Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(opinion_scale): add average and median stats #20

Merged

Conversation

arszh
Copy link
Contributor

@arszh arszh commented Nov 25, 2019

Description

Added average and median stats to opinion_scale.
Added questionStatisticsAdapter.
Added test for opinion_scale average and median.
Updated snapshot to this change.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Related Issue

#10

Motivation and Context

Simplifies understanding of question results

How Has This Been Tested?

Data from typeform, snapshot and test in adapter.test.js

Screenshots (if appropriate):

Checklist:

  • I have updated the documentation (if required).
  • I have read the CONTRIBUTING document.
  • [xI have added tests to cover my changes.
  • All new and existing tests passed.
  • I added a picture of a cute animal cause it's fun

add average and median stats to opinion_scale
add questionStatisticsAdapter
add test for opinion_scale average ana median
update snapshot to this change

close lirantal#10
@codecov-io
Copy link

Codecov Report

Merging #20 into master will increase coverage by 0.89%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   95.53%   96.42%   +0.89%     
==========================================
  Files           4        6       +2     
  Lines         112      140      +28     
  Branches       21       24       +3     
==========================================
+ Hits          107      135      +28     
  Misses          5        5
Impacted Files Coverage Δ
src/Form/Utils/MathUtils.js 100% <100%> (ø)
src/Form/Adapters/questionStatisticsAdapters.js 100% <100%> (ø)
src/Form/Form.js 93.33% <100%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c730b1c...6c2e710. Read the comment docs.

@lirantal lirantal self-requested a review November 25, 2019 22:19
@lirantal lirantal added the enhancement New feature or request label Nov 25, 2019
Copy link
Owner

@lirantal lirantal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thank you! ❤️

@lirantal
Copy link
Owner

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants