Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPI tarball is missing test_websocket.py #65

Closed
basak opened this issue Mar 14, 2014 · 1 comment
Closed

PyPI tarball is missing test_websocket.py #65

basak opened this issue Mar 14, 2014 · 1 comment

Comments

@basak
Copy link
Contributor

basak commented Mar 14, 2014

Hi,

I'm doing some QA of this module in Ubuntu, which is coming into Ubuntu through the Debian package, which is based on the PyPI tarball.

We have a policy of automatically running upstream tests when our packages are built where possible. We can't do that with this module, since the tests are missing from the Python sdist tarball.

Please can you add the file to the PyPI tarball distribution, so that others can also run your tests? I think you can do this by tweaking setup.py to include it.

Thanks!

@basak
Copy link
Contributor Author

basak commented Mar 14, 2014

Note that the data/ directory is also missing, and would needed to be added together with test_websocket.py to the PyPI tarball for tests to work.

@liris liris closed this as completed in 4900b04 Mar 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant