Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this package still supported? #55

Open
Rastusik opened this issue Oct 4, 2022 · 2 comments
Open

Is this package still supported? #55

Rastusik opened this issue Oct 4, 2022 · 2 comments
Labels

Comments

@Rastusik
Copy link

Rastusik commented Oct 4, 2022

Hey @lisachenko , is this package still supported? Does it make sense to create a pull request with php 8.1 support?

@lisachenko
Copy link
Owner

Hello, @Rastusik! I'm not actively working on OSS projects right now, but if you want to work on this - I can give you maintainer permissions on this project, or can review and merge your PRs to enable 8.1/8.2 repos.

@Rastusik
Copy link
Author

Rastusik commented Oct 11, 2022

@lisachenko that sounds great! I'm not really planning to be a real maintainer, but I can make contributions for PHP 8/8.1/8.2 support. If you think it's ok to give me maintainer permissions, I won't object, but I'm only planning to do work related to this: https://github.com/pixelfederation/swoole-bundle/blob/coroutines/docs/configuration-reference.md#additional-info-for-coroutines-usage . Which essentially is just support for newer php versions (with working tests of course). I won't have time for anything more.

Btw FYI even tests for PHP 8.0 are failing, I fixed them in my fork here: https://github.com/pixelfederation/z-engine/commits/8.0_fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants