Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override titlepage template epub #105

Merged

Conversation

Geobert
Copy link
Contributor

@Geobert Geobert commented Jan 3, 2023

This allows to override epub.titlepage.xhtml and fixes a bug in the output message of the progress bar (the file was correctly generated).

Geobert Quach added 2 commits January 3, 2023 19:35
I found that `-t pdf -s story.md` was printing
`pdf: generated .\auto`
instead of
`pdf: generated .\story.pdf`

Bug introduced with the `indicatif` upgrade
@Geobert
Copy link
Contributor Author

Geobert commented Jan 3, 2023

Also a question:

warning: fields `short_message` and `issue_type` are never read
  --> src/lib\grammar_check.rs:38:9
   |
34 | struct GrammarError {
   |        ------------ fields in this struct
...
38 |     pub short_message: Option<String>,
   |         ^^^^^^^^^^^^^
39 |     pub issue_type: Option<String>,
   |         ^^^^^^^^^^
   |

Are these fields used somewhere else (when using crowbook as a lib)?

@crowdagger
Copy link
Owner

Thanks for the PR, sorry for the enormous delay. And no those fields are not use, I really need to do some cleaning one of these days :)

@crowdagger crowdagger merged commit 522383b into crowdagger:master Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants