Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative repeat count does nothing at /usr/share/perl5/NeedRestart/UI.pm line 141, <STDIN> line 3. #166

Closed
casimirextreme opened this issue Sep 25, 2019 · 8 comments
Labels
Milestone

Comments

@casimirextreme
Copy link

Hi,

I'm use ansible to fire needrestart on Debian Stretch and Buster and I get this:

$ ansible -K -m raw server-farm -a "needrestart -rl"
SUDO password: 
192.168.100.100 | SUCCESS | rc=0 >>

Negative repeat count does nothing at /usr/share/perl5/NeedRestart/UI.pm line 141, <STDIN> line 3.
Negative repeat count does nothing at /usr/share/perl5/NeedRestart/UI.pm line 141.
Negative repeat count does nothing at /usr/share/perl5/NeedRestart/UI.pm line 141.
Negative repeat count does nothing at /usr/share/perl5/NeedRestart/UI.pm line 141.
...
<Same lines hundred of times>
...
Negative repeat count does nothing at /usr/share/perl5/NeedRestart/UI.pm line 141.
Scanning processes...
Negative repeat count does nothing at /usr/share/perl5/NeedRestart/UI.pm line 141.
Negative repeat count does nothing at /usr/share/perl5/NeedRestart/UI.pm line 141.
Negative repeat count does nothing at /usr/share/perl5/NeedRestart/UI.pm line 152.
Scanning linux images...

Running kernel seems to be up-to-date.

No services need to be restarted.

No containers need to be restarted.

No user sessions are running outdated binaries.
Shared connection to 192.168.100.100 closed.

Any idea what could be wrong?

@liske liske added the bug label Oct 15, 2019
@liske
Copy link
Owner

liske commented Oct 15, 2019

This is the progress bar implementation and might be triggered if ncurses detects a very small number of terminal columns.

@liske liske added this to the v3.5 milestone Oct 15, 2019
@libnoon
Copy link
Contributor

libnoon commented Oct 21, 2019

This should be fixed by this pull request: #167

@casimirextreme
Copy link
Author

casimirextreme commented Oct 23, 2019

Hi. Thanks for your help.

I now have this where running locally:

needrestart -ra

Scanning processes... [ Scanning processes... [= Scanning processes... [== Scanning processes... [=== Scanning processes... [==== Scanning processes... [===== Scanning processes... [====== Scanning processes... [======= Scanning processes... [======== Scanning processes... [========== Scanning processes... [=========== Scanning processes... [============ Scanning processes... [============= Scanning processes... [============== Scanning processes... [=============== Scanning processes... [================ Scanning processes... [================= Scanning processes... [=================== Scanning processes... [==================== Scanning processes... [===================== Scanning processes... [====================== Scanning processes... [======================= Scanning processes... [======================== Scanning processes... [========================= Scanning processes... [========================== Scanning processes... [============================ Scanning processes... [============================= Scanning processes... [============================== Scanning processes... [=============================== Scanning processes... [================================ Scanning processes... [================================= Scanning processes... [================================== Scanning processes... [=================================== Scanning processes... [===================================== Scanning processes... [====================================== Scanning processes... [======================================= Scanning processes... [======================================== Scanning processes... [========================================= Scanning processes... [========================================== Scanning processes... [=========================================== Scanning processes... [============================================ Scanning processes... [============================================== Scanning processes... [=============================================== Scanning processes... [================================================ Scanning processes... [================================================= Scanning processes... [================================================== Scanning processes... [=================================================== Scanning processes... [==================================================== Scanning processes... [===================================================== Scanning processes... [======================================================= Scanning processes... [======================================================== Scanning processes... [========================================================= Scanning processes... [========================================================== Scanning processes... [=========================================================== Scanning processes... [============================================================ Scanning processes... [=============================================================
Scanning processes... [============================================================== Scanning processes... [================================================================ Scanning processes... [================================================================= Scanning processes... [================================================================== Scanning processes... [=================================================================== Scanning processes... [==================================================================== Scanning processes... [===================================================================== Scanning processes... [====================================================================== Scanning processes... [======================================================================= Scanning processes... [========================================================================= Scanning processes... [========================================================================== Scanning processes... [=========================================================================== Scanning processes... [============================================================================ Scanning processes... [============================================================================= Scanning processes... [============================================================================== Scanning processes... [=============================================================================== Scanning processes... [================================================================================ Scanning processes... [================================================================================== Scanning processes... [=================================================================================== Scanning processes... [==================================================================================== Scanning processes... [===================================================================================== Scanning processes... [====================================================================================== Scanning processes... [======================================================================================= Scanning processes... [======================================================================================== Scanning processes... [========================================================================================= Scanning processes... [=========================================================================================== Scanning processes... [============================================================================================ Scanning processes... [============================================================================================= Scanning processes... [============================================================================================== Scanning processes... [=============================================================================================== Scanning processes... [================================================================================================ Scanning processes... [================================================================================================= Scanning processes... [================================================================================================== Scanning processes... [==================================================================================================== Scanning processes... [===================================================================================================== Scanning processes... [====================================================================================================== Scanning processes... [======================================================================================================= Scanning processes... [======================================================================================================== Scanning processes... [========================================================================================================= Scanning processes... [========================================================================================================== Scanning processes... [=========================================================================================================== Scanning processes... [============================================================================================================= Scanning processes... [============================================================================================================== Scanning processes... [=============================================================================================================== Scanning processes... [================================================================================================================ Scanning processes... [================================================================================================================= Scanning processes... [================================================================================================================== Scanning processes... [=================================================================================================================== Scanning processes... [==================================================================================================================== Scanning processes... [====================================================================================================================== Scanning processes... [======================================================================================================================= Scanning processes... [======================================================================================================================== Scanning processes... [========================================================================================================================= Scanning processes... [========================================================================================================================== Scanning processes... [=========================================================================================================================== Scanning processes... [============================================================================================================================ Scanning processes... [============================================================================================================================= Scanning processes... [=============================================================================================================================== Scanning processes... [================================================================================================================================ Scanning processes... [================================================================================================================================= Scanning processes... [================================================================================================================================== Scanning processes... [=================================================================================================================================== Scanning processes... [==================================================================================================================================== Scanning processes... [===================================================================================================================================== Scanning processes... [====================================================================================================================================== Scanning processes... [=======================================================================================================================================Scanning processes...
Scanning linux images... [ Scanning linux images... [================================================================== Scanning linux images... [====================================================================================================================================Scanning linux images...

Running kernel seems to be up-to-date.

No services need to be restarted.

No containers need to be restarted.

No user sessions are running outdated binaries.

and this from ansible:

192.168.100.100 | SUCCESS | rc=0 >>
Scanning processes...                                                           =]
Scanning linux images...                                                        =]

Increasing $Text::Wrap::columns from 0 to 3 to accommodate length of subsequent tab at /usr/share/perl5/NeedRestart/UI.pm line 55.
Ru
 n
 n
 i
 n
 g
 k
 e
 r
 n
 e
 l
 s
 e
 e
 m
 s
 t
 o
 b
 e
 u
 p
 -
 t
 o
 -
 d
 a
 t
 e
 .

No
 s
 e
 r
 v
 i
 c
 e
 s
 n
 e
 e
 d
 t
 o
 b
 e
 r
 e
 s
 t
 a
 r
 t
 e
 d
 .

No
 c
 o
 n
 t
 a
 i
 n
 e
 r
 s
 n
 e
 e
 d
 t
 o
 b
 e
 r
 e
 s
 t
 a
 r
 t
 e
 d
 .

No
 u
 s
 e
 r
 s
 e
 s
 s
 i
 o
 n
 s
 a
 r
 e
 r
 u
 n
 n
 i
 n
 g
 o
 u
 t
 d
 a
 t
 e
 d
 b
 i
 n
 a
 r
 i
 e
 s
 .
Shared connection to 192.168.100.100 closed.

@libnoon
Copy link
Contributor

libnoon commented Oct 25, 2019

@casimirextreme I have updated my pull request, could you please retry?
Thanks a lot for testing.

@casimirextreme
Copy link
Author

@casimirextreme I have updated my pull request, could you please retry?
Thanks a lot for testing.

This is perfect now :)

192.168.100.100 | SUCCESS | rc=0 >>
Scanning processes...                                                           
Scanning linux images...                                                        

Running kernel seems to be up-to-date.

No services need to be restarted.

No containers need to be restarted.

No user sessions are running outdated binaries.
Shared connection to 192.168.100.100 closed.

Thanks a lot for the fix!

@libnoon
Copy link
Contributor

libnoon commented Oct 26, 2019

@casimirextreme we don't know yet if the maintainer will merge my pull request, so I'd suggest to reopen/keep this bug open until it is merged...

@casimirextreme
Copy link
Author

Indeed. Sorry.
Ticket has been reopened.

@liske
Copy link
Owner

liske commented Nov 8, 2019

Closing after merging #167.

@liske liske closed this as completed Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants